!86 merge wc/doc into main

fix(ohos): fire dialog-completion notification when the desktop app is minimized

Created-by: SWangHash
Commit-by: SWangHash
Merged-by: SWangHash
Description: ## Summary

<!-- Briefly describe what changed. -->

Fixes #

## Type and Areas

Type:

<!-- Feature / bug fix / regression fix / refactor / UI/UX / docs / test / CI / dependency / other. -->

Areas:

<!-- Rust core, desktop/Tauri, web UI, mobile web, server/relay, AI adapters, installer, docs, etc. -->

## Motivation / Impact

<!-- What problem does this solve, and what changes for users or developers? Write "No direct user-facing change" if applicable. -->

## Verification

<!-- List exact commands, manual checks, and outcomes. For docs-only or template-only changes, use the lightest relevant checks or explain why runtime checks were skipped. -->

## Reviewer Notes

<!-- Optional: screenshots, architecture notes, compatibility risks, migration notes, or rollback guidance. -->

## Checklist

- [ ] This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
- [ ] Relevant verification is recorded above, or skipped checks are explained.
- [ ] User-facing strings, docs, and locales are updated where applicable.


See merge request: OpenHarmonyPCDeveloper/BitFun!86

Author: SWangHash

src/apps/desktop/src/api/system_api.rs

@@ -1114,6 +1114,32 @@ pub async fn send_system_notification(
     Err("No notification provided".to_string())
 }
 
+/// When a system-level error occurs while the desktop window is minimized,
+/// surface it as an OS notification directly from the host (Rust -> ArkTS),
+/// bypassing the web-ui. `AgenticEvent::SystemError` is filtered out of the
+/// frontend projection, so the web-ui's dialog-completion notification path
+/// never sees it; this is the only path that reflects system errors while the
+/// app is minimized. On non-OHOS hosts the window-state query returns an error
+/// (no ArkTS function registered) and this no-ops, matching the stub
+/// `send_system_notification` Tauri path.
+pub async fn notify_system_error_if_minimized(error: &str) {
+    let Ok(minimized) = crate::api::ohos::window::window_is_minimized().await else {
+        return;
+    };
+    if !minimized {
+        return;
+    }
+    // The error string may carry a multi-line trace; the notification body
+    // only needs the first line to be useful.
+    let body = error.lines().next().unwrap_or(error).to_string();
+    let payload = serde_json::json!({ "title": "BitFun system error", "body": body });
+    if let Err(e) =
+        crate::api::ohos::ohos_file_system::send_system_notification_ohos(payload.to_string()).await
+    {
+        log::warn!("Failed to send system-error notification: {e}");
+    }
+}
+
 #[cfg(test)]
 mod tests {
     #[test]

src/apps/desktop/src/lib.rs

@@ -2524,6 +2524,17 @@ async fn deliver_event_to_webview(
     session_event_journal: &SessionEventJournal,
 ) {
     let cursor = session_event_journal.record(&event);
+    // SystemError is filtered out of the frontend projection, so the web-ui's
+    // dialog-completion notification path never sees it. Surface it directly
+    // from the host when the window is minimized, so system-level errors are
+    // still reflected via an OS notification. Fire-and-forget so the event
+    // delivery loop is not blocked on the ArkTS round-trip.
+    if let AgenticEvent::SystemError { error, .. } = &event {
+        let error_text = error.clone();
+        tokio::spawn(async move {
+            crate::api::system_api::notify_system_error_if_minimized(&error_text).await;
+        });
+    }
     let Some(mut projected) = bitfun_events::project_agentic_frontend_event(event) else {
         log::warn!("Unhandled AgenticEvent type in desktop delivery");
         return;

src/web-ui/src/app/hooks/dialogCompletionNotifyPolicy.ts

@@ -11,6 +11,7 @@ interface DialogCompletionNotificationInput {
 interface DialogCompletionNotificationCopyInput {
   sessionTitle?: string | null;
   success?: boolean | null;
+  cancelled?: boolean;
   finishReason?: string | null;
   t: (key: string, options?: Record<string, unknown>) => string;
 }
@@ -40,22 +41,36 @@ export function shouldSendDialogCompletionNotification({
 export function buildDialogCompletionNotificationCopy({
   sessionTitle,
   success,
+  cancelled,
   finishReason,
   t,
 }: DialogCompletionNotificationCopyInput): { title: string; body: string } {
   const trimmedTitle = sessionTitle?.trim();
   const failed = success === false;
+  // Cancelled takes precedence over failed/completed: a cancelled turn is a
+  // distinct terminal state the user should see as "cancelled", not "stopped".
+  const titleKey = cancelled
+    ? 'notify.dialogCancelledTitle'
+    : failed
+      ? 'notify.dialogFailedTitle'
+      : 'notify.dialogCompletedTitle';
+  const withSessionKey = cancelled
+    ? 'notify.dialogCancelledWithSession'
+    : failed
+      ? 'notify.dialogFailedWithSession'
+      : 'notify.dialogCompletedWithSession';
+  const fallbackKey = cancelled
+    ? 'notify.dialogCancelledFallback'
+    : failed
+      ? 'notify.dialogFailedFallback'
+      : 'notify.dialogCompletedFallback';
   const options = {
     sessionTitle: trimmedTitle,
     finishReason,
   };
 
   return {
-    title: failed
-      ? t('notify.dialogFailedTitle')
-      : t('notify.dialogCompletedTitle'),
-    body: trimmedTitle
-      ? t(failed ? 'notify.dialogFailedWithSession' : 'notify.dialogCompletedWithSession', options)
-      : t(failed ? 'notify.dialogFailedFallback' : 'notify.dialogCompletedFallback', options),
+    title: t(titleKey),
+    body: trimmedTitle ? t(withSessionKey, options) : t(fallbackKey, options),
   };
 }

src/web-ui/src/app/hooks/useDialogCompletionNotify.test.ts

@@ -126,6 +126,10 @@ describe('buildDialogCompletionNotificationCopy', () => {
     if (key === 'notify.dialogFailedWithSession') {
       return `${options?.sessionTitle} stopped unexpectedly.`;
     }
+    if (key === 'notify.dialogCancelledTitle') return 'BitFun task cancelled';
+    if (key === 'notify.dialogCancelledWithSession') {
+      return `${options?.sessionTitle} was cancelled.`;
+    }
     return 'A BitFun session is ready.';
   };
 
@@ -166,4 +170,17 @@ describe('buildDialogCompletionNotificationCopy', () => {
       body: 'Browser control fix stopped unexpectedly.',
     });
   });
+
+  it('uses cancelled copy when the turn was cancelled', () => {
+    expect(
+      buildDialogCompletionNotificationCopy({
+        sessionTitle: 'Refactor plan',
+        cancelled: true,
+        t,
+      }),
+    ).toEqual({
+      title: 'BitFun task cancelled',
+      body: 'Refactor plan was cancelled.',
+    });
+  });
 });

src/web-ui/src/app/hooks/useDialogCompletionNotify.ts

@@ -1,11 +1,13 @@
 import { useEffect, useRef } from 'react';
 import { agentAPI } from '@/infrastructure/api';
+import type { AgenticEvent } from '@/infrastructure/api/service-api/AgentAPI';
 import { systemAPI } from '@/infrastructure/api/service-api/SystemAPI';
 import { configManager } from '@/infrastructure/config/services/ConfigManager';
 import { flowChatStore } from '@/flow_chat/store/FlowChatStore';
 import { useI18n } from '@/infrastructure/i18n';
 import { createLogger } from '@/shared/utils/logger';
 import { isOpenHarmonyRuntime } from '@/infrastructure/runtime';
+import { workspaceAPI } from '@/infrastructure';
 import {
   buildDialogCompletionNotificationCopy,
   shouldSendDialogCompletionNotification,
@@ -14,15 +16,18 @@ import {
 const log = createLogger('useDialogCompletionNotify');
 
 /**
- * Listens for dialog turn completion events and sends an OS-level desktop
- * notification (Windows toast / macOS notification center) when the window
- * is not focused and the feature is enabled in config.
+ * Listens for dialog turn completion AND failure events and sends an OS-level
+ * desktop notification (Windows toast / macOS notification center / HarmonyOS
+ * Notification Kit) when the window is not focused and the feature is enabled
+ * in config.
  *
- * Notification title = session title (or short session id fallback).
- * Notification body  = fixed "task completed" message.
+ * Notification title = product title, success vs. failure variant.
+ * Notification body  = session-aware "is ready" / "stopped unexpectedly" copy.
  *
- * "Not focused" means: the page is hidden (minimized / tab switched) OR
- * the window has lost focus to another OS-level application.
+ * "Not focused" means: the page is hidden (minimized / tab switched) OR the
+ * window has lost focus to another OS-level application. On HarmonyOS the
+ * webview does not reliably update document.hidden / fire window blur on
+ * minimize, so the real minimized state is queried from the host instead.
  */
 export const useDialogCompletionNotify = () => {
   const { t } = useI18n('common');
@@ -36,9 +41,26 @@ export const useDialogCompletionNotify = () => {
     window.addEventListener('focus', handleFocus);
     window.addEventListener('blur', handleBlur);
 
-    const unlisten = agentAPI.onDialogTurnCompleted(async (event) => {
-      // Send notification if page is hidden OR window lost OS focus
-      const isBackground = document.hidden || !windowFocusedRef.current;
+    const resolveIsBackground = async (): Promise<boolean> => {
+      // On HarmonyOS the webview does not reliably update document.hidden or
+      // fire window blur on minimize, so query the real window status from the
+      // host. The diagnostic log below still captures document.hidden /
+      // windowFocused for comparison.
+      if (isOpenHarmonyRuntime()) {
+        try {
+          return await workspaceAPI.window_is_minimized();
+        } catch {
+          return document.hidden || !windowFocusedRef.current;
+        }
+      }
+      return document.hidden || !windowFocusedRef.current;
+    };
+
+    const notify = async (
+      event: AgenticEvent,
+      outcome: { success?: boolean; cancelled?: boolean; finishReason?: string | null },
+    ): Promise<void> => {
+      const isBackground = await resolveIsBackground();
 
       let enabled = true;
       try {
@@ -82,8 +104,9 @@ export const useDialogCompletionNotify = () => {
 
       const notificationCopy = buildDialogCompletionNotificationCopy({
         sessionTitle: session?.title,
-        success: event?.success,
-        finishReason: event?.finishReason ?? event?.finish_reason,
+        success: outcome.success,
+        cancelled: outcome.cancelled,
+        finishReason: outcome.finishReason ?? undefined,
         t,
       });
 
@@ -94,12 +117,29 @@ export const useDialogCompletionNotify = () => {
         notificationCopy.title,
         notificationCopy.body,
       );
-    });
+    };
+
+    // A completed turn may itself be unsuccessful (success === false). A
+    // DialogTurnFailed event carries an explicit error string, surfaced here
+    // as the finish reason so the failure copy reflects what happened. A
+    // DialogTurnCancelled event is a distinct terminal state shown as
+    // "cancelled" rather than "stopped".
+    const unlistenCompleted = agentAPI.onDialogTurnCompleted((event) =>
+      notify(event, { success: event?.success ?? true, finishReason: event?.finishReason ?? event?.finish_reason })
+    );
+    const unlistenFailed = agentAPI.onDialogTurnFailed((event) =>
+      notify(event, { success: false, finishReason: event?.error })
+    );
+    const unlistenCancelled = agentAPI.onDialogTurnCancelled((event) =>
+      notify(event, { cancelled: true })
+    );
 
     return () => {
       window.removeEventListener('focus', handleFocus);
       window.removeEventListener('blur', handleBlur);
-      unlisten();
+      unlistenCompleted();
+      unlistenFailed();
+      unlistenCancelled();
     };
   }, [t]);
 };

src/web-ui/src/locales/en-US/common.json

@@ -1650,6 +1650,9 @@
     "dialogFailedTitle": "BitFun task stopped",
     "dialogFailedWithSession": "\"{{sessionTitle}}\" stopped unexpectedly. Return to BitFun to review the reason.",
     "dialogFailedFallback": "A BitFun session stopped unexpectedly. Return to BitFun to review the reason.",
+    "dialogCancelledTitle": "BitFun task cancelled",
+    "dialogCancelledWithSession": "\"{{sessionTitle}}\" was cancelled. Return to BitFun to continue.",
+    "dialogCancelledFallback": "A BitFun session was cancelled. Return to BitFun to continue.",
     "permissionRequestTitle": "BitFun requires approval",
     "permissionRequestBody": "An action is waiting for your approval.",
     "permissionRequestBatchBody": "{{count}} actions are waiting for your approval."

src/web-ui/src/locales/zh-CN/common.json

@@ -1650,6 +1650,9 @@
     "dialogFailedTitle": "BitFun 任务已中断",
     "dialogFailedWithSession": "“{{sessionTitle}}” 已异常停止，可以回到 BitFun 查看原因。",
     "dialogFailedFallback": "有一个 BitFun 会话已异常停止，可以回到应用查看原因。",
+    "dialogCancelledTitle": "BitFun 任务已取消",
+    "dialogCancelledWithSession": "“{{sessionTitle}}” 已取消，可以回到 BitFun 继续。",
+    "dialogCancelledFallback": "有一个 BitFun 会话已取消，可以回到应用继续。",
     "permissionRequestTitle": "BitFun 需要你的审批",
     "permissionRequestBody": "有一项操作正在等待你的审批。",
     "permissionRequestBatchBody": "有 {{count}} 项操作正在等待你的审批。"

src/web-ui/src/locales/zh-TW/common.json

@@ -1650,6 +1650,9 @@
     "dialogFailedTitle": "BitFun 任務已中斷",
     "dialogFailedWithSession": "「{{sessionTitle}}」已異常停止，可以回到 BitFun 查看原因。",
     "dialogFailedFallback": "有一個 BitFun 會話已異常停止，可以回到應用查看原因。",
+    "dialogCancelledTitle": "BitFun 任務已取消",
+    "dialogCancelledWithSession": "「{{sessionTitle}}」已取消，可以回到 BitFun 繼續。",
+    "dialogCancelledFallback": "有一個 BitFun 會話已取消，可以回到應用繼續。",
     "permissionRequestTitle": "BitFun 需要你的審批",
     "permissionRequestBody": "有一項操作正在等待你的審批。",
     "permissionRequestBatchBody": "有 {{count}} 項操作正在等待你的審批。"