Support stderr output via stream option#26
Open
joshwlewis wants to merge 3 commits into
Open
Conversation
When successfully ending with this error, the `options` were undefined because we were missing a param.
fix: missing logUpdater param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CLI commands that aim to be used as a part of a pipe, it's more appropriate to put human-readable and informational logs on
stderr. This renderer only supportsstdoutas it is. This PR adds the option to render to other streams likestderrby passing in a stream option like{ stream: process.stderr }.