use map instead of broadcast for Tensor operators#380
Merged
Conversation
ChrisRackauckas
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For deeply nested tensor products (4 or more), cheap operations like
adjointandsizeget slowdowns and start to allocate. The reason seems to be the combination of broadcasting and nested tuples. This can be fixed by replacing e.g.adjoint.(L.ops)withmap(adjoint, L.ops). This PR replaces all such uses of broadcast withmapfor TensorProductOperator and TensorSumOperator.Here are some benchmarks: