Skip to content

Commit b990edc

Browse files
committed
fix: fix embed binary ios simulator device version
1 parent 6255840 commit b990edc

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

assets/embed_binary.cmake

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,15 @@ function(embed_binary INPUT_PATH INPUT_FILE OUTPUT_OBJ_VAR)
3434
endif()
3535
if(CMAKE_OSX_DEPLOYMENT_TARGET)
3636
if(CMAKE_SYSTEM_NAME STREQUAL "iOS")
37-
list(APPEND _asm_flags "-mios-version-min=${CMAKE_OSX_DEPLOYMENT_TARGET}")
37+
# Distinguish device vs simulator: -mios-version-min tags objects as iOS
38+
# device, while -mios-simulator-version-min tags them as iOS simulator.
39+
# Using the wrong flag causes linker errors ("built for 'iOS'" when
40+
# linking for iOS-simulator).
41+
if(CMAKE_OSX_SYSROOT MATCHES "iphonesimulator")
42+
list(APPEND _asm_flags "-mios-simulator-version-min=${CMAKE_OSX_DEPLOYMENT_TARGET}")
43+
else()
44+
list(APPEND _asm_flags "-mios-version-min=${CMAKE_OSX_DEPLOYMENT_TARGET}")
45+
endif()
3846
else()
3947
list(APPEND _asm_flags "-mmacosx-version-min=${CMAKE_OSX_DEPLOYMENT_TARGET}")
4048
endif()

0 commit comments

Comments
 (0)