From 7b357876c06ad725b9bf9015a86549c93c9350ae Mon Sep 17 00:00:00 2001 From: MD4 Date: Thu, 11 Jun 2026 11:31:08 +0200 Subject: [PATCH 1/2] fix(*): trigger publish workflows on lerna tag format The JS publish workflows triggered on 'sdk-/v*' tags, but lerna (independent mode) creates tags as '@screeb/@', so the workflows never ran on release. Align the 5 JS workflow triggers to lerna's actual tag format. Also remove the root 'publish' script: with CI publishing on tag push, 'npm run version' (tags only) is the documented flow, and the local 'lerna publish' would double-publish. --- .github/workflows/publish-angular.yml | 2 +- .github/workflows/publish-browser.yml | 2 +- .github/workflows/publish-react.yml | 2 +- .github/workflows/publish-reactnative.yml | 2 +- .github/workflows/publish-vue.yml | 2 +- package.json | 1 - 6 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/publish-angular.yml b/.github/workflows/publish-angular.yml index 0cb22ea..9c053db 100644 --- a/.github/workflows/publish-angular.yml +++ b/.github/workflows/publish-angular.yml @@ -3,7 +3,7 @@ name: Publish @screeb/sdk-angular on: push: tags: - - 'sdk-angular/v*' + - '@screeb/sdk-angular@*' jobs: publish: diff --git a/.github/workflows/publish-browser.yml b/.github/workflows/publish-browser.yml index 2369ce2..58b7fc3 100644 --- a/.github/workflows/publish-browser.yml +++ b/.github/workflows/publish-browser.yml @@ -3,7 +3,7 @@ name: Publish @screeb/sdk-browser on: push: tags: - - 'sdk-browser/v*' + - '@screeb/sdk-browser@*' jobs: publish: diff --git a/.github/workflows/publish-react.yml b/.github/workflows/publish-react.yml index f7d04be..8b0dfa3 100644 --- a/.github/workflows/publish-react.yml +++ b/.github/workflows/publish-react.yml @@ -3,7 +3,7 @@ name: Publish @screeb/sdk-react on: push: tags: - - 'sdk-react/v*' + - '@screeb/sdk-react@*' jobs: publish: diff --git a/.github/workflows/publish-reactnative.yml b/.github/workflows/publish-reactnative.yml index d19f2af..27a08b3 100644 --- a/.github/workflows/publish-reactnative.yml +++ b/.github/workflows/publish-reactnative.yml @@ -3,7 +3,7 @@ name: Publish @screeb/react-native on: push: tags: - - 'sdk-reactnative/v*' + - '@screeb/react-native@*' jobs: publish: diff --git a/.github/workflows/publish-vue.yml b/.github/workflows/publish-vue.yml index 61d7db9..1897b02 100644 --- a/.github/workflows/publish-vue.yml +++ b/.github/workflows/publish-vue.yml @@ -3,7 +3,7 @@ name: Publish @screeb/sdk-vue on: push: tags: - - 'sdk-vue/v*' + - '@screeb/sdk-vue@*' jobs: publish: diff --git a/package.json b/package.json index 0d33623..dffbe23 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,6 @@ "lint:commit": "commitlint --verbose --edit", "lint:fix": "lerna run --parallel lint -- --fix", "prepare": "npm run build && husky install", - "publish": "npm run version && lerna publish --no-private", "start": "lerna run start", "test": "lerna run --parallel test", "upgrade:all": "npm-upgrade && lerna exec --concurrency 1 npm-upgrade", From 79fbe0450ac08db241ac79aef7b347b06b088a38 Mon Sep 17 00:00:00 2001 From: MD4 Date: Thu, 11 Jun 2026 11:33:23 +0200 Subject: [PATCH 2/2] docs(*): fix `CONTRIBUTING.md` release script --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 26dc38f..e751c42 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -48,7 +48,7 @@ Each package is released independently. Releases are triggered by pushing a git ```bash # JS packages — use Lerna -npx lerna version --scope=@screeb/sdk-browser +npm run version # Flutter # 1. Bump version in packages/sdk-flutter/pubspec.yaml