Update RCC to v20.3.3 and Action Server to 2.16.2#237
Conversation
There was a problem hiding this comment.
Pull Request Overview
Bump embedded tool versions to align with latest releases.
- Update RCC to v20.3.3 across client, Python helper, dev scripts, and CI.
- Update Action Server to 2.16.2 and reflect changes in changelog.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sema4ai/vscode-client/src/rcc.ts | Updates RCC_VERSION used by VS Code client to download RCC. |
| sema4ai/src/sema4ai_code/rcc.py | Updates RCC_VERSION used by Python tooling to download RCC. |
| sema4ai/src/sema4ai_code/action_server.py | Bumps ACTION_SERVER_VERSION to 2.16.2. |
| docs/changelog.md | Updates changelog entries for RCC and Action Server versions. |
| devutils/develop.sh | Updates RCC download URL for macOS/Linux in dev setup script. |
| devutils/develop.bat | Updates RCC download URL for Windows in dev setup script. |
| .github/workflows/build_environments.yaml | Updates RCC_VERSION environment variable in CI workflow. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| } | ||
| const RCC_VERSION = "v20.3.2"; | ||
| const RCC_VERSION = "v20.3.3"; |
There was a problem hiding this comment.
RCC version is hardcoded here and also duplicated in sema4ai/src/sema4ai_code/rcc.py, devutils/develop.sh, devutils/develop.bat, and .github/workflows/build_environments.yaml. Consider centralizing RCC_VERSION in a single source (e.g., a versions.json or .env file) and importing/reading it here to avoid future drift; for example, export RCC_VERSION from a shared module and import it into this file.
| from sema4ai_code.tools import download_tool | ||
|
|
||
| RCC_VERSION = "v20.3.2" | ||
| RCC_VERSION = "v20.3.3" |
There was a problem hiding this comment.
RCC version is hardcoded and duplicated across multiple files (TypeScript client, dev scripts, and CI). To reduce maintenance overhead, read this from a single shared source (e.g., a versions.json or an environment variable loaded at runtime) rather than embedding the string in multiple places.
|
|
||
| # Get RCC binary based on platform | ||
| RCC_URL="https://cdn.sema4.ai/rcc/releases/v20.3.2" | ||
| RCC_URL="https://cdn.sema4.ai/rcc/releases/v20.3.3" |
There was a problem hiding this comment.
This embeds the RCC version directly in the URL and duplicates the same version string used elsewhere. Suggest sourcing a versions.env (e.g., RCC_VERSION=v20.3.3) and building the URL from $RCC_VERSION to keep a single source of truth.
| echo | ||
| :: Get RCC, binary with which we're going to create the master environment. | ||
| SET rccUrl=https://cdn.sema4.ai/rcc/releases/v20.3.2/windows64/rcc.exe | ||
| SET rccUrl=https://cdn.sema4.ai/rcc/releases/v20.3.3/windows64/rcc.exe |
There was a problem hiding this comment.
Hardcoded RCC version duplicates the same value across the repo. Consider loading RCC_VERSION from a shared file (e.g., a simple versions.txt) or environment so both .bat and .sh scripts consume the same value without needing code changes for each bump.
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| RCC_VERSION: v20.3.2 | ||
| RCC_VERSION: v20.3.3 |
There was a problem hiding this comment.
Instead of hardcoding the RCC version in the workflow, consider using a repository variable or workflow input to avoid editing the workflow on each bump. Example: RCC_VERSION: ${{ vars.RCC_VERSION }} and define RCC_VERSION in repository Variables.
| RCC_VERSION: v20.3.3 | |
| RCC_VERSION: ${{ vars.RCC_VERSION }} |
No description provided.