Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_environments.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
build_environments:
runs-on: ${{ matrix.os }}
env:
RCC_VERSION: v20.3.2
RCC_VERSION: v20.3.3
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding the RCC version in the workflow, consider using a repository variable or workflow input to avoid editing the workflow on each bump. Example: RCC_VERSION: ${{ vars.RCC_VERSION }} and define RCC_VERSION in repository Variables.

Suggested change
RCC_VERSION: v20.3.3
RCC_VERSION: ${{ vars.RCC_VERSION }}

Copilot uses AI. Check for mistakes.
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion devutils/develop.bat
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ SET activatePath=%scriptPath%\activate.bat

echo
:: Get RCC, binary with which we're going to create the master environment.
SET rccUrl=https://cdn.sema4.ai/rcc/releases/v20.3.2/windows64/rcc.exe
SET rccUrl=https://cdn.sema4.ai/rcc/releases/v20.3.3/windows64/rcc.exe
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded RCC version duplicates the same value across the repo. Consider loading RCC_VERSION from a shared file (e.g., a simple versions.txt) or environment so both .bat and .sh scripts consume the same value without needing code changes for each bump.

Copilot uses AI. Check for mistakes.
IF NOT EXIST "%rccPath%" (
curl -o %rccPath% %rccUrl% --fail || goto env_error
)
Expand Down
2 changes: 1 addition & 1 deletion devutils/develop.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ ACTIVATE_PATH="$SCRIPT_PATH/activate.sh"
echo

# Get RCC binary based on platform
RCC_URL="https://cdn.sema4.ai/rcc/releases/v20.3.2"
RCC_URL="https://cdn.sema4.ai/rcc/releases/v20.3.3"
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This embeds the RCC version directly in the URL and duplicates the same version string used elsewhere. Suggest sourcing a versions.env (e.g., RCC_VERSION=v20.3.3) and building the URL from $RCC_VERSION to keep a single source of truth.

Copilot uses AI. Check for mistakes.
if [[ "$(uname)" == "Darwin" ]]; then
RCC_URL="$RCC_URL/macos-arm64/rcc"
else
Expand Down
4 changes: 2 additions & 2 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
- Improve the error messages when data server is not running
- Agent Spec validation on enums relaxed to warnings.
- Embedding signed `uv` v0.8.17
- RCC v20.3.2
- Action Server 2.16.0
- RCC v20.3.3
- Action Server 2.16.2

## New in 2.15.0 (2025-09-12)

Expand Down
2 changes: 1 addition & 1 deletion sema4ai/src/sema4ai_code/action_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
log = get_logger(__name__)

ONE_MINUTE_S = 60
ACTION_SERVER_VERSION = "2.16.1"
ACTION_SERVER_VERSION = "2.16.2"

if typing.TYPE_CHECKING:
from sema4ai_code.vendored_deps.url_callback_server import LastRequestInfoTypedDict
Expand Down
2 changes: 1 addition & 1 deletion sema4ai/src/sema4ai_code/rcc.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def download_rcc(
"""
from sema4ai_code.tools import download_tool

RCC_VERSION = "v20.3.2"
RCC_VERSION = "v20.3.3"
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RCC version is hardcoded and duplicated across multiple files (TypeScript client, dev scripts, and CI). To reduce maintenance overhead, read this from a single shared source (e.g., a versions.json or an environment variable loaded at runtime) rather than embedding the string in multiple places.

Copilot uses AI. Check for mistakes.
download_tool(
Tool.RCC,
location,
Expand Down
2 changes: 1 addition & 1 deletion sema4ai/vscode-client/src/rcc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ async function downloadRcc(
throw new Error("Currently only Linux amd64 is supported.");
}
}
const RCC_VERSION = "v20.3.2";
const RCC_VERSION = "v20.3.3";
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RCC version is hardcoded here and also duplicated in sema4ai/src/sema4ai_code/rcc.py, devutils/develop.sh, devutils/develop.bat, and .github/workflows/build_environments.yaml. Consider centralizing RCC_VERSION in a single source (e.g., a versions.json or .env file) and importing/reading it here to avoid future drift; for example, export RCC_VERSION from a shared module and import it into this file.

Copilot uses AI. Check for mistakes.
const prefix = "https://cdn.sema4.ai/rcc/releases/" + RCC_VERSION;
const url: string = prefix + relativePath;
return await downloadWithProgress(url, progress, token, location);
Expand Down
Loading