Skip to content

ENG-33: CVE updates#245

Merged
kariharju merged 7 commits into
masterfrom
ENG-33
Dec 18, 2025
Merged

ENG-33: CVE updates#245
kariharju merged 7 commits into
masterfrom
ENG-33

Conversation

@kariharju
Copy link
Copy Markdown
Contributor

@kariharju kariharju commented Dec 17, 2025

Description

  • Updated CVES
  • Moved from yarn to npm and using npm ci in GHAs
    • npm caching done correctly with package-lock.json in git
  • Moved from vsce to @vscode/vsce AND using it from locked dev. deps (not downloading in GHAs)
  • Big updates to sema4ai/.vscodeignore a lot of extra files dropped from the vsix
  • Updated codegen:
    • Better organized package.json
    • with open(..., "w", encoding="utf-8", newline="\n") in a lot of places causing white-space diffs

https://linear.app/sema4ai/issue/ENG-33

How was this tested?

  • Ran extension in VS Code > tested agent and action edits and runs
  • Build local vsix > installed > tested agent and action edits and runs

Screenshots (if possible)

Before .vscodeignore changes:

 INFO  Files included in the VSIX:
sema4ai-2.18.0.vsix
├─ [Content_Types].xml
├─ extension.vsixmanifest
└─ extension/
   ├─ .nvmrc [0.01 KB]
   ├─ .prettierignore [0.11 KB]
   ├─ .yarnrc.yml [0.03 KB]
   ├─ README.md [2.99 KB]
   ├─ console.ts
   ├─ dev.py [12.35 KB]
   ├─ package.json [67.08 KB]
   ├─ poetry.lock [137.43 KB]
   ├─ pyproject.toml [3.13 KB]
   ├─ .mypy_cache/ (2589 files) [71.97 MB]
   ├─ .ruff_cache/ (23 files) [12.78 KB]
   ├─ bin/ (12 files) [109.2 MB]
   ├─ codegen/ (5 files) [70.45 KB]
   ├─ images/ (10 files) [1.91 MB]
   ├─ node_modules/ (418 files) [1.94 MB]
   ├─ src/ (297 files) [3.81 MB]
   └─ vscode-client/ (133 files) [2.41 MB]

=> Run vsce ls --tree to see all included files.

 DONE  Packaged: C:\Projects\github\vscode-extension\sema4ai\sema4ai-2.18.0.vsix (3498 files, 102.41 MB

..after:

 INFO  Files included in the VSIX:
sema4ai-2.18.0.vsix
├─ [Content_Types].xml
├─ extension.vsixmanifest
└─ extension/
   ├─ package.json [67.08 KB]
   ├─ readme.md [2.99 KB]
   ├─ bin/ (12 files) [109.2 MB]
   ├─ images/ (10 files) [1.91 MB]
   ├─ node_modules/ (337 files) [1.54 MB]
   ├─ src/ (297 files) [3.81 MB]
   └─ vscode-client/ (65 files) [2.04 MB]

=> Run vsce ls --tree to see all included files.

 DONE  Packaged: C:\Projects\github\vscode-extension\sema4ai\sema4ai-2.18.0.vsix (725 files, 96.74 MB)

Pre-Release checklist:

  • Updated the Unreleased section of /docs/changelog.md with the new changes.

Stable Release checklist:

  • Updated the version using python -m dev set-version {version}
  • Updated /docs/changelog.md with the changes for the release

- Setup the GHAs correctly for 'npm ci'
- instead of obsolete `vsce` use `@vscode/vsce` and use it via locked dev-deps instead of loading in GHA directly
Fixed utf-8 and linefeeds in codegen.
@kariharju kariharju marked this pull request as ready for review December 17, 2025 18:03
fetch-tags: true
- name: Setup node
uses: actions/setup-node@v4
uses: actions/setup-node@v6
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you touched it, maybe it'd be nice to actually pin it with the hash...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've been hoping to avoid it, kind of wishing these would just get the semver support, but I guess that is wishful thinking.
Maintaining the hashes on +400 repositories is absolute insanity, compared to having something like ^6.1.2
I'll try to get everything to v6 and using the caching correctly first then some massive search and replace agent or bot.

Copy link
Copy Markdown
Contributor

@fabioz fabioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one optional comment ;)

@kariharju kariharju merged commit 8810920 into master Dec 18, 2025
17 checks passed
@kariharju kariharju deleted the ENG-33 branch December 18, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants