Conversation
- Setup the GHAs correctly for 'npm ci' - instead of obsolete `vsce` use `@vscode/vsce` and use it via locked dev-deps instead of loading in GHA directly
Fixed utf-8 and linefeeds in codegen.
fabioz
reviewed
Dec 17, 2025
| fetch-tags: true | ||
| - name: Setup node | ||
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@v6 |
Contributor
There was a problem hiding this comment.
Since you touched it, maybe it'd be nice to actually pin it with the hash...
Contributor
Author
There was a problem hiding this comment.
Yeah I've been hoping to avoid it, kind of wishing these would just get the semver support, but I guess that is wishful thinking.
Maintaining the hashes on +400 repositories is absolute insanity, compared to having something like ^6.1.2
I'll try to get everything to v6 and using the caching correctly first then some massive search and replace agent or bot.
fabioz
reviewed
Dec 17, 2025
Contributor
fabioz
left a comment
There was a problem hiding this comment.
LGTM, just one optional comment ;)
fabioz
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
npm ciin GHAsvsceto@vscode/vsceAND using it from locked dev. deps (not downloading in GHAs)sema4ai/.vscodeignorea lot of extra files dropped from the vsixwith open(..., "w", encoding="utf-8", newline="\n")in a lot of places causing white-space diffshttps://linear.app/sema4ai/issue/ENG-33
How was this tested?
Screenshots (if possible)
Before .vscodeignore changes:
..after:
Pre-Release checklist:
/docs/changelog.mdwith the new changes.Stable Release checklist:
python -m dev set-version {version}/docs/changelog.mdwith the changes for the release