Skip to content

Commit 759b646

Browse files
author
Polerca
committed
Related to release v1.4.0
1 parent f7aafa1 commit 759b646

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

custom-project/oag-template.html

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
fr: Gabarit BVG
55
description: Integration
66

7-
modified: 2025-04-11
7+
modified: 2026-03-31
88
lastReviewAbout: Initial implementation of the custom template
99
componentName: oag-template
1010
sponsor: OAG onboarding team
1111

12-
statusUpdate: 2025-04-11 - Intial creation of this documents
12+
statusUpdate: 2026-03-31 - Working on release v1.4.1 or v1.5.0
1313

1414
pages:
1515
examples:
@@ -18,9 +18,14 @@
1818
path: https://servicecanada.github.io/oag-template/index.html
1919

2020
maintenancePlan:
21-
- due: Next release (for v1.1 or v1.0.1)
21+
- due: Next release (for v1.4 +)
22+
what: Migrate in a long term solution and remove the temporary CSS that was added to mitigate the XSS clean up by the removal of the font element. There is a total of 4 CSS class which are: 'tmp-fx-charcoal', 'tmp-fx-fs-08em', 'tmp-fx-black' and 'tmp-fx-purple-trillium'. This file must be addressed/eliminated: /assets/oag-font-css-fix.css
23+
rationale: Inline styles could generate unexpected and make hard to trace rendering concern while the authoring tool are maintained and increase the technical debt. Use CSS class with accompanying working example help to define the expected behaviour and to ensure they continue to work as expected once made available through the authoring tool.
24+
- due: Next release (for v1.4 +)
2225
what: Reduce number of includes necessary by adapting GCWeb's own includes
2326
rationale: Having many include overrides could increase the technical debt of this project. By adapting GCWeb Jekyll to leverage different parameters, we'll be able to minimize the need for include overrides.
27+
status: Need to be assessed
28+
updated: 2025-04-11
2429
- due: Next release (for v1.1 or v1.0.1)
2530
what: "Add <code>&lt;title></code> and <code>&lt;xml></code> elements in SVG markup (ref: https://github.com/wet-boew/GCWeb/blob/master/sites/assets/sig-blk-en.svg?short_path=5922cb9)"
2631
rationale: SVG's should be of high quality
@@ -30,7 +35,12 @@
3035
observation: Some main menu items do not have sub-menu items, which is not standard for the main menu.
3136

3237
todos:
38+
- On about 300+ published pages there is trace of inline style, those need to be replaced by long term solution that leverage CSS class and be demoed by the reference implementation. Future update/configuration to the authoring tool could add emphasis on this task.
3339
- Implement dynamic approach for home page tiles.
3440

41+
requirement:
42+
- Any addition to this file are prohibited: /assets/oag-font-css-fix.css
43+
- Those temporary CSS can not be used anywhere else except to the single working example page: /assets/oag-font-css-fix.css
44+
3545
output: false
3646
---

0 commit comments

Comments
 (0)