Skip to content

Commit 1296be5

Browse files
committed
update log messages
1 parent f2ad59a commit 1296be5

2 files changed

Lines changed: 3 additions & 11 deletions

File tree

FluentValidation.AutoValidation.Endpoints/src/Filters/FluentValidationAutoValidationEndpointFilter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public class FluentValidationAutoValidationEndpointFilter(ILogger<FluentValidati
5454

5555
if (!validationResult.IsValid)
5656
{
57-
logger.LogDebug("Validation result not valid for argument '{Argument}': {ErrorCount} validation errors found.", argument.GetType().Name, validationResult.Errors.Count);
57+
logger.LogDebug("Validation result not valid for argument '{Argument}': {ErrorCount} validation error(s) found.", argument.GetType().Name, validationResult.Errors.Count);
5858

5959
var fluentValidationAutoValidationResultFactory = serviceProvider.GetService<IFluentValidationAutoValidationResultFactory>();
6060

FluentValidation.AutoValidation.Mvc/src/Filters/FluentValidationAutoValidationActionFilter.cs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public async Task OnActionExecutionAsync(ActionExecutingContext actionExecutingC
100100

101101
if (!validationResult.IsValid)
102102
{
103-
logger.LogDebug("Validation result not valid for parameter '{Parameter}' of type '{Type}' for action '{Action}' on controller '{Controller}': {ErrorCount} validation errors found.", parameter.Name, parameterType.Name, controllerActionDescriptor.ActionName, controllerActionDescriptor.ControllerName, validationResult.Errors.Count);
103+
logger.LogDebug("Validation result not valid for parameter '{Parameter}' of type '{Type}' for action '{Action}' on controller '{Controller}': {ErrorCount} validation error(s) found.", parameter.Name, parameterType.Name, controllerActionDescriptor.ActionName, controllerActionDescriptor.ControllerName, validationResult.Errors.Count);
104104

105105
foreach (var error in validationResult.Errors)
106106
{
@@ -134,12 +134,8 @@ public async Task OnActionExecutionAsync(ActionExecutingContext actionExecutingC
134134
{
135135
logger.LogTrace("Action result created for action '{Action}' on controller '{Controller}'.", controllerActionDescriptor.ActionName, controllerActionDescriptor.ControllerName);
136136
}
137-
else
138-
{
139-
logger.LogTrace("No action result created for action '{Action}' on controller '{Controller}'.", controllerActionDescriptor.ActionName, controllerActionDescriptor.ControllerName);
140-
}
141137

142-
return;
138+
logger.LogTrace("No action result created for action '{Action}' on controller '{Controller}'.", controllerActionDescriptor.ActionName, controllerActionDescriptor.ControllerName);
143139
}
144140

145141
logger.LogDebug("ModelState is valid for action '{Action}' on controller '{Controller}'. Proceeding with action execution.", controllerActionDescriptor.ActionName, controllerActionDescriptor.ControllerName);
@@ -184,10 +180,6 @@ private void HandleUnvalidatedEntries(ActionExecutingContext context)
184180
modelStateEntry.ValidationState = ModelValidationState.Skipped;
185181
}
186182
}
187-
else
188-
{
189-
logger.LogDebug("Skipping validation of unvalidated entries due to DisableBuiltInModelValidation being set to false.");
190-
}
191183
}
192184
}
193185
}

0 commit comments

Comments
 (0)