Skip to content

Commit 3bc6f43

Browse files
committed
docs: capture deferred review recommendations in task list
Add PR 4b review recommendations from Sheldon (source maps) and Kara (stale caniuse-lite) as prerequisite notes on PR 6 (Vite migration), where both issues naturally resolve. This ensures the deferred items are not lost between PRs.
1 parent df77031 commit 3bc6f43

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

docs/tasks/tasks-prd-typescript-migration.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,10 @@ Use Graphite (gt) commands for managing stacked branches:
278278

279279
- [ ] 6. Rollup 1 + Babel → Vite Library Mode (PR 6)
280280

281+
> **Deferred from PR 4b review:**
282+
> - **Update `caniuse-lite`** before this PR. The current version (1.0.30000989, circa 2019) resolves `"last 3 Chrome versions"` to Chrome 73-75 instead of current versions. This had no impact in PR 4b (no Babel transform plugins consume targets), but Vite's `build.target` will consume browserslist — stale data would produce incorrect output.
283+
> - **Source maps for minification** were not added in PR 4b (terser replaced UglifyJS without source map config, matching the original behavior). Vite's library mode handles source maps natively, so this resolves itself when terser is removed.
284+
281285
- [ ] 6.1. Create new branch using `gt create typescript-migration-part-6`
282286

283287
- [ ] 6.2. Install `vite` and configure `vite.config.ts` for library mode:

0 commit comments

Comments
 (0)