You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running a command to create a worker results in an empty worker_name. By default, we should translate the "docker_image": "org/image" to be one of the following:
"worker_name": "org/image" or
"worker_name": "org_image" or
"worker_name": "org-image" or
"worker_name": "image"
When creating a worker with the same image repeatedly. We should decide if we want to avoid duplicates and enforce uniqueness based on docker_image or worker_name. Whatever we decide, we should enforce it.
I vote for worker_name based uniqueness.
I have tested that if I pass in the same worker name right now (not talking about empty or defaults anymore), it creates a new id for me every time in the DB, and we can improve upon that as it doesn't seem desirable.
Suggestion:
"docker_image": "org/image"to be one of the following:"worker_name": "org/image"or"worker_name": "org_image"or"worker_name": "org-image"or"worker_name": "image"docker_imageorworker_name. Whatever we decide, we should enforce it.worker_namebased uniqueness.