From 96f0bb71a9ba4c9a4f6b4df3bfeafe1876e7b889 Mon Sep 17 00:00:00 2001
From: ash1shkumar <rashishkumar2006@gmail.com>
Date: Sat, 6 Jun 2026 01:13:00 +0530
Subject: [PATCH] refactor: consolidate analytics computation logic

---
 .../analytics-comp/PerformanceSummary.tsx     | 186 ++++++++++++++----
 1 file changed, 150 insertions(+), 36 deletions(-)

diff --git a/frontend/app/components/analytics-comp/PerformanceSummary.tsx b/frontend/app/components/analytics-comp/PerformanceSummary.tsx
index 48ef34a..01d89af 100644
--- a/frontend/app/components/analytics-comp/PerformanceSummary.tsx
+++ b/frontend/app/components/analytics-comp/PerformanceSummary.tsx
@@ -1,6 +1,10 @@
 "use client";
 
-export type AnalyticsMetric = "completed" | "assigned";
+import { useMemo } from "react";
+
+export type AnalyticsMetric =
+  | "completed"
+  | "assigned";
 
 export type MemberPerformance = {
   id: string;
@@ -17,18 +21,73 @@ export type MemberPerformance = {
 type PerformanceSummaryProps = {
   members: MemberPerformance[];
   metric: AnalyticsMetric;
-  onMetricChange: (metric: AnalyticsMetric) => void;
+  onMetricChange: (
+    metric: AnalyticsMetric
+  ) => void;
 };
 
+function calculateTotals(
+  members: MemberPerformance[]
+) {
+  return members.reduce(
+    (acc, member) => {
+      acc.completed +=
+        member.completed;
+      acc.assigned +=
+        member.assigned;
+      acc.reviews +=
+        member.reviews;
+
+      return acc;
+    },
+    {
+      completed: 0,
+      assigned: 0,
+      reviews: 0,
+    }
+  );
+}
+
+function calculateCompletionRate(
+  completed: number,
+  assigned: number
+) {
+  return assigned > 0
+    ? Math.round(
+        (completed / assigned) *
+          100
+      )
+    : 0;
+}
+
 export default function PerformanceSummary({
   members,
   metric,
   onMetricChange,
 }: PerformanceSummaryProps) {
-  const completedTotal = members.reduce((sum, member) => sum + member.completed, 0);
-  const assignedTotal = members.reduce((sum, member) => sum + member.assigned, 0);
-  const reviewTotal = members.reduce((sum, member) => sum + member.reviews, 0);
-  const completionRate = Math.round((completedTotal / assignedTotal) * 100);
+  const analyticsTotals =
+    useMemo(
+      () =>
+        calculateTotals(
+          members
+        ),
+      [members]
+    );
+
+  const completedTotal =
+    analyticsTotals.completed;
+
+  const assignedTotal =
+    analyticsTotals.assigned;
+
+  const reviewTotal =
+    analyticsTotals.reviews;
+
+  const completionRate =
+    calculateCompletionRate(
+      completedTotal,
+      assignedTotal
+    );
 
   return (
     <section>
@@ -37,23 +96,44 @@ export default function PerformanceSummary({
           <h2 className="font-headline-lg text-headline-lg text-primary">
             Contribution Analytics
           </h2>
+
           <p className="text-body-md text-on-surface-variant">
-            Explore workload balance, delivery velocity, and review activity by sprint.
+            Explore workload
+            balance, delivery
+            velocity, and review
+            activity by sprint.
           </p>
         </div>
 
         <div className="grid grid-cols-3 gap-3 text-center">
           <div className="rounded-lg bg-surface-container-low px-4 py-3">
-            <p className="text-label-md text-on-surface-variant">Completion</p>
-            <p className="font-headline-md text-primary">{completionRate}%</p>
+            <p className="text-label-md text-on-surface-variant">
+              Completion
+            </p>
+
+            <p className="font-headline-md text-primary">
+              {completionRate}%
+            </p>
           </div>
+
           <div className="rounded-lg bg-surface-container-low px-4 py-3">
-            <p className="text-label-md text-on-surface-variant">Completed</p>
-            <p className="font-headline-md text-primary">{completedTotal}</p>
+            <p className="text-label-md text-on-surface-variant">
+              Completed
+            </p>
+
+            <p className="font-headline-md text-primary">
+              {completedTotal}
+            </p>
           </div>
+
           <div className="rounded-lg bg-surface-container-low px-4 py-3">
-            <p className="text-label-md text-on-surface-variant">Reviews</p>
-            <p className="font-headline-md text-primary">{reviewTotal}</p>
+            <p className="text-label-md text-on-surface-variant">
+              Reviews
+            </p>
+
+            <p className="font-headline-md text-primary">
+              {reviewTotal}
+            </p>
           </div>
         </div>
       </header>
@@ -62,19 +142,32 @@ export default function PerformanceSummary({
         <div className="flex flex-col gap-4 sm:flex-row sm:items-end sm:justify-between mb-8">
           <div>
             <h3 className="font-headline-md text-headline-md">
-              Task Completion Velocity
+              Task Completion
+              Velocity
             </h3>
+
             <p className="font-label-md text-label-md text-on-surface-variant">
-              Toggle between completed work and assigned workload.
+              Toggle between
+              completed work and
+              assigned workload.
             </p>
           </div>
 
           <div className="flex rounded-lg bg-surface-container-low p-1 font-label-md">
-            {(["completed", "assigned"] as const).map((item) => (
+            {(
+              [
+                "completed",
+                "assigned",
+              ] as const
+            ).map((item) => (
               <button
                 key={item}
                 type="button"
-                onClick={() => onMetricChange(item)}
+                onClick={() =>
+                  onMetricChange(
+                    item
+                  )
+                }
                 className={`rounded-md px-4 py-2 capitalize transition ${
                   metric === item
                     ? "bg-primary text-on-primary shadow-sm"
@@ -88,28 +181,49 @@ export default function PerformanceSummary({
         </div>
 
         <div className="grid grid-cols-2 gap-5 sm:grid-cols-3 lg:grid-cols-6 min-h-72 items-end">
-          {members.map((member) => {
-            const activeValue = member[metric];
-            return (
-              <div key={member.id} className="flex h-full flex-col items-center justify-end gap-3">
-                <div className="relative flex h-56 w-full items-end justify-center rounded-lg bg-surface-container-low px-3 pt-3">
-                  <div
-                    className="w-full rounded-t-lg bg-primary transition-all duration-300"
-                    style={{ height: `${activeValue}%` }}
-                    title={`${member.name}: ${activeValue}% ${metric}`}
-                  />
-                  <span className="absolute top-3 rounded-full bg-surface px-2 py-1 text-xs font-bold text-primary shadow-sm">
-                    {activeValue}%
+          {members.map(
+            (member) => {
+              const activeValue =
+                member[
+                  metric
+                ];
+
+              return (
+                <div
+                  key={
+                    member.id
+                  }
+                  className="flex h-full flex-col items-center justify-end gap-3"
+                >
+                  <div className="relative flex h-56 w-full items-end justify-center rounded-lg bg-surface-container-low px-3 pt-3">
+                    <div
+                      className="w-full rounded-t-lg bg-primary transition-all duration-300"
+                      style={{
+                        height: `${activeValue}%`,
+                      }}
+                      title={`${member.name}: ${activeValue}% ${metric}`}
+                    />
+
+                    <span className="absolute top-3 rounded-full bg-surface px-2 py-1 text-xs font-bold text-primary shadow-sm">
+                      {
+                        activeValue
+                      }
+                      %
+                    </span>
+                  </div>
+
+                  <span className="max-w-full truncate font-label-md text-on-surface-variant">
+                    {member.name
+                      .split(
+                        " "
+                      )[0]}
                   </span>
                 </div>
-                <span className="max-w-full truncate font-label-md text-on-surface-variant">
-                  {member.name.split(" ")[0]}
-                </span>
-              </div>
-            );
-          })}
+              );
+            }
+          )}
         </div>
       </div>
     </section>
   );
-}
+}
\ No newline at end of file