Describe the bug
The SauerPaiMachine ODEs are taken directly from Equation (15.13) in Power System Modelling and Scripting by F. Milano. There is a typo in the book itself that appears to have been propagated into the Sienna code.
Expected behavior
In mdl_machine_ode! defined for SauerPaiMachine, the $\gamma_{d2}$ in the last term should instead be $\gamma_{q2}$.
Link to the incorrect $\gamma_{d2}$ parameter that needs to be changed: https://github.com/NREL-Sienna/PowerSimulationsDynamics.jl/blob/main/src/models/generator_models/machine_models.jl#L204C73-L204C77
Screenshots
The page in Milano defining these equations is shown below with annotations. Equations (15.12) and (15.13) are supposed to be equivalent. Specifically, they are related in the following way:
- (15.13.A) =(15.12.C) plugged into (15.12.A)
- (15.13.B) = (15.12.D) plugged into (15.12.B)
- (15.13.C) = (15.12.C)
- (15.13.D) = (15.12.D)
However, a typo occurred during the (15.13.B) substitution step (bullet 2 above). The coefficient of $e_{d}'$ is $\gamma_{d2}$ but it should be $\gamma_{q2}$.
Describe the bug
The
SauerPaiMachineODEs are taken directly from Equation (15.13) in Power System Modelling and Scripting by F. Milano. There is a typo in the book itself that appears to have been propagated into the Sienna code.Expected behavior$\gamma_{d2}$ in the last term should instead be $\gamma_{q2}$ .$\gamma_{d2}$ parameter that needs to be changed: https://github.com/NREL-Sienna/PowerSimulationsDynamics.jl/blob/main/src/models/generator_models/machine_models.jl#L204C73-L204C77
In
mdl_machine_ode!defined forSauerPaiMachine, theLink to the incorrect
Screenshots
The page in Milano defining these equations is shown below with annotations. Equations (15.12) and (15.13) are supposed to be equivalent. Specifically, they are related in the following way:
However, a typo occurred during the (15.13.B) substitution step (bullet 2 above). The coefficient of$e_{d}'$ is $\gamma_{d2}$ but it should be $\gamma_{q2}$ .