fix(vocab): guard promotion input — refuse non-term + already-approved (own review)

promote() now refuses a non-GlossaryTerm input and an already-approved term (no silent mutation),
and uses .get('id') so malformed input can't KeyError. Two teeth added; 7 total.

Author: mdheller

tools/promote_glossary_term.py

@@ -58,9 +58,19 @@ def _method_failures(term: dict, alignment: dict, peer: dict | None) -> list[str
 
 
 def promote(term: dict, alignment: dict, peer: dict | None = None) -> dict:
+    # Input guard — only promote an actual draft GlossaryTerm; a non-term or an already-approved
+    # term is not a valid promotion target (don't silently mutate it).
+    if term.get("type") != "GlossaryTerm" or not str(term.get("id") or "").strip():
+        return {"promoted": False, "term": term.get("id"), "status": term.get("status"),
+                "refused": "not-a-draft-glossary-term",
+                "detail": "promotion input must be a GlossaryTerm with an id"}
+    if term.get("status") == "approved":
+        return {"promoted": False, "term": term["id"], "status": "approved",
+                "refused": "already-approved", "detail": "term is already approved — nothing to promote"}
+
     fails = _method_failures(term, alignment, peer)
     if fails:
-        return {"promoted": False, "term": term.get("id"), "status": "draft",
+        return {"promoted": False, "term": term["id"], "status": "draft",
                 "refused": "incomplete-alignment", "unaligned": fails,
                 "detail": "draft->approved refused: an approved term must be captured + vector-aligned "
                           "+ implemented (fail-closed meet); it stays draft"}

tools/validate_glossary_promotion.py

@@ -71,6 +71,18 @@ def main() -> int:
     else:
         CHECKS["off-space-embedding:refused"] = True
 
+    # 5. Input guards — a non-term and an already-approved term are both refused (no silent mutation).
+    r = P.promote({"id": "x", "type": "NotATerm"}, alignment, peer)
+    if r.get("promoted") or r.get("refused") != "not-a-draft-glossary-term":
+        FAILURES.append("a non-GlossaryTerm input must be refused")
+    else:
+        CHECKS["non-term-input:refused"] = True
+    r = P.promote({**draft, "status": "approved"}, alignment, peer)
+    if r.get("promoted") or r.get("refused") != "already-approved":
+        FAILURES.append("an already-approved term must be refused (nothing to promote)")
+    else:
+        CHECKS["already-approved:refused"] = True
+
     for m in FAILURES:
         print(f"FAIL: {m}", file=sys.stderr)
     ok = not FAILURES and all(CHECKS.values())