Skip to content

[Bug] System accent color not used #155

@nicolaspaillard

Description

@nicolaspaillard

Step 1. Pre-report Checklist

  • I checked if there is already an open issue that described my problem.
  • I checked if there is already an open issue at Millennium that describes my problem.
  • I ticked the checkboxes without reading them.
  • I checked the Update tab to see if there was an update.

Step 2. Theme configuration

Configuration
{
"general": {
  "accentColor": "#f7630c",
  "checkForMillenniumUpdates": true,
  "checkForPluginAndThemeUpdates": true,
  "injectCSS": true,
  "injectJavascript": true,
  "millenniumUpdateChannel": "stable",
  "onMillenniumUpdate": 1,
  "shouldShowThemePluginUpdateNotifications": false
},
"general.checkForMillenniumUpdates": false,
"misc": {
  "hasShownWelcomeModal": true
},
"notifications": {
  "showNotifications": true,
  "showPluginNotifications": true,
  "showUpdateNotifications": true
},
"plugins": {
  "enabledPlugins": [
    "luatools"
  ]
},
"plugins.enabledPlugins": [],
"themes": {
  "activeTheme": "Steam",
  "allowedScripts": true,
  "allowedStyles": true,
  "conditions": {
    "Steam": {
      "Community - Profile pages header": "no",
      "Community - VAC-Ban visibility": "Show",
      "General - Achievement Notification": "no",
      "General - Always show sidebar": "Enabled",
      "General - Big Picture Mode button": "yes",
      "General - Font": "Be Vietnam Pro (default)",
      "General - Friend icon": "no",
      "General - Friend list button": "no",
      "General - Game Overlay": "no",
      "General - Mica & Acrylic plugin support": "no",
      "General - Navigation buttons": "no",
      "General - News button": "yes",
      "General - Notification button": "no",
      "General - Sidebar only on hover": "no",
      "General - Steam VR button": "yes",
      "General - System accent colors": "yes",
      "General - Userpannel": "no",
      "General - Wallet balance": "no",
      "General - Window Controls": "Show",
      "Library - Add shelf button": "no",
      "Library - Always show game infos": "yes",
      "Library - Banner Infos": "no",
      "Library - Banner position": "Middle (default)",
      "Library - Bigger banner": "yes",
      "Library - Darken not installed games": "yes",
      "Library - Game cover shiny effect": "no",
      "Library - Game info box artwork": "no",
      "Library - Sidebar on left": "no",
      "Library - Steam-Custom-Artowrks Support": "no",
      "Library - Steam-Custom-Artworks Support": "no",
      "Library - What's New": "Compact",
      "Store - Broadcast": "yes",
      "Store - Digital product info": "no",
      "Store - Follow the creators": "no",
      "Store - Footer": "no",
      "Store - Gamepage": "yes",
      "Store - Info sidebar on right": "no",
      "Store - Landing Header": "no",
      "Store - Recommendations": "yes",
      "Store - Sidebar only on hover": "no",
      "Store - SteamDeck & Giftcard": "Both",
      "Store - URL bar": "no",
      "Store - Write a Review": "no"
    }
  },
  "themeColors": {
    "Steam": {
      "--accent-1": "102, 108, 255",
      "--accent-2": "135, 140, 255",
      "--background": "10, 10, 10",
      "--blue": "75, 137, 239",
      "--blue-hover": "100, 154, 242",
      "--color-1": "17, 17, 17",
      "--color-2": "30, 30, 30",
      "--color-3": "20, 20, 20",
      "--color-4": "24, 24, 24",
      "--color-5": "38, 41, 44",
      "--color-6": "38, 38, 41",
      "--green": "36, 166, 90",
      "--green-hover": "39, 185, 100",
      "--red": "240, 74, 74",
      "--red-hover": "242, 99, 99",
      "--st-accent-1": "102, 108, 255",
      "--st-accent-2": "135, 140, 255",
      "--st-background": "10, 10, 10",
      "--st-blue": "75, 137, 239",
      "--st-blue-hover": "100, 154, 242",
      "--st-color-1": "17, 17, 17",
      "--st-color-2": "30, 30, 30",
      "--st-color-3": "20, 20, 20",
      "--st-color-4": "24, 24, 24",
      "--st-color-5": "38, 41, 44",
      "--st-color-6": "38, 38, 41",
      "--st-green": "36, 166, 90",
      "--st-green-hover": "39, 185, 100",
      "--st-red": "240, 74, 74",
      "--st-red-hover": "242, 99, 99",
      "--st-yellow": "239, 141, 75",
      "--st-yellow-hover": "239, 141, 75",
      "--yellow": "239, 141, 75",
      "--yellow-hover": "239, 141, 75"
    }
  }
}
}

Step 3. Describe the issue

System accent colors button in the steam theme config is not working
I checked the code, and it overrides the --accent-1 and --accent-2 colors, but your theme uses --st-accent-1 and --st-accent-2

Step 4. How to reproduce

Millenium -> themes -> spacetheme -> configure -> enable "general - system accent colors"

Anything else?

Fixed it by adding custom css to millenium

:root{
  --st-accent-1: var(--accent-1) !important;
  --st-accent-2: var(--accent-2) !important;
}

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

Status

To triage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions