Skip to content

Commit 2754bf6

Browse files
committed
refactor : #43 불필요한 코드 수정
1 parent b9bee1d commit 2754bf6

File tree

3 files changed

+18
-23
lines changed

3 files changed

+18
-23
lines changed

src/main/java/com/demo/pteam/trainer/address/mapper/TrainerAddressMapper.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.demo.pteam.trainer.address.domain.Coordinates;
44
import com.demo.pteam.trainer.address.domain.TrainerAddress;
5+
import com.demo.pteam.trainer.address.repository.entity.TrainerAddressEntity;
56
import com.demo.pteam.trainer.profile.controller.dto.TrainerProfileRequest;
67

78
public class TrainerAddressMapper {
@@ -20,4 +21,18 @@ public static TrainerAddress toDomain(TrainerProfileRequest.Address dto) {
2021
);
2122
}
2223

24+
// 도메인 -> 엔티티 변환
25+
public static TrainerAddressEntity toEntity(TrainerAddress address) {
26+
Coordinates coordinates = address.getCoordinates();
27+
28+
return TrainerAddressEntity.builder()
29+
.numberAddress(address.getNumberAddress())
30+
.roadAddress(address.getRoadAddress())
31+
.detailAddress(address.getDetailAddress())
32+
.postalCode(address.getPostalCode())
33+
.latitude(coordinates.getLatitude())
34+
.longitude(coordinates.getLongitude())
35+
.build();
36+
}
37+
2338
}

src/main/java/com/demo/pteam/trainer/address/repository/TrainerAddressRepositoryImpl.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.demo.pteam.trainer.address.domain.Coordinates;
44
import com.demo.pteam.trainer.address.domain.TrainerAddress;
5+
import com.demo.pteam.trainer.address.mapper.TrainerAddressMapper;
56
import com.demo.pteam.trainer.address.repository.entity.TrainerAddressEntity;
67
import lombok.RequiredArgsConstructor;
78
import org.springframework.stereotype.Repository;
@@ -16,15 +17,7 @@ public class TrainerAddressRepositoryImpl implements TrainerAddressRepository {
1617

1718
@Override
1819
public TrainerAddress save(TrainerAddress address) {
19-
TrainerAddressEntity entity = TrainerAddressEntity.builder()
20-
.numberAddress(address.getNumberAddress())
21-
.roadAddress(address.getRoadAddress())
22-
.detailAddress(address.getDetailAddress())
23-
.postalCode(address.getPostalCode())
24-
.latitude(address.getCoordinates().getLatitude())
25-
.longitude(address.getCoordinates().getLongitude())
26-
.build();
27-
20+
TrainerAddressEntity entity = TrainerAddressMapper.toEntity(address);
2821
TrainerAddressEntity saved = jpaRepository.save(entity);
2922

3023
Coordinates coordinates = new Coordinates(

src/main/java/com/demo/pteam/trainer/profile/service/TrainerProfileService.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,12 @@
1616
import com.demo.pteam.trainer.profile.repository.TrainerProfileRepository;
1717
import com.demo.pteam.trainer.profile.repository.entity.TrainerProfileEntity;
1818
import lombok.RequiredArgsConstructor;
19-
import lombok.extern.slf4j.Slf4j;
2019
import org.springframework.stereotype.Service;
2120
import org.springframework.transaction.annotation.Transactional;
2221

2322
@Service
2423
@RequiredArgsConstructor
2524
@Transactional
26-
@Slf4j
2725
public class TrainerProfileService {
2826

2927
private final TrainerProfileRepository trainerProfileRepository;
@@ -37,18 +35,6 @@ public class TrainerProfileService {
3735
*/
3836
public void createProfile(TrainerProfileRequest request, Long userId) {
3937
// TODO: '회원'이 아닌 '트레이너' 확인 여부
40-
log.info("📌 profileImg = {}", request.getProfileImg());
41-
log.info("📌 intro = {}", request.getIntro());
42-
log.info("📌 credit = {}", request.getCredit());
43-
log.info("📌 contactStartTime = {}", request.getContactStartTime());
44-
log.info("📌 contactEndTime = {}", request.getContactEndTime());
45-
log.info("📌 isNamePublic = {}", request.getIsNamePublic());
46-
47-
TrainerProfileRequest.Address addr = request.getAddress();
48-
log.info("📍 address.roadAddress = {}", addr.getRoadAddress());
49-
log.info("📍 address.detailAddress = {}", addr.getDetailAddress());
50-
log.info("📍 address.latitude = {}", addr.getLatitude());
51-
log.info("📍 address.longitude = {}", addr.getLongitude());
5238

5339
TrainerAddress newAddress = TrainerAddressMapper.toDomain(request.getAddress());
5440

@@ -92,6 +78,7 @@ public void createProfile(TrainerProfileRequest request, Long userId) {
9278
if (profile.isInvalidContactTimePair()) {
9379
throw new ApiException(TrainerProfileErrorCode.INVALID_CONTACT_TIME_PAIR);
9480
}
81+
9582
if (profile.isInvalidContactTimeRange()) {
9683
throw new ApiException(TrainerProfileErrorCode.INVALID_CONTACT_TIME_RANGE);
9784
}

0 commit comments

Comments
 (0)