fix(auth): verify passwords on login and add claim flow for orphan ac…#75
Open
sarahhashash wants to merge 1 commit into
Open
fix(auth): verify passwords on login and add claim flow for orphan ac…#75sarahhashash wants to merge 1 commit into
sarahhashash wants to merge 1 commit into
Conversation
…counts
The /api/auth/login route was upserting users by email and issuing a
session without ever checking the supplied password. Two problems:
1. Anyone who knew an email could sign in as that user.
2. Every email ever typed into the form became a real User row,
with passwordHash = NULL.
Login now does a findUnique + bcrypt.compare against the stored hash,
and returns a generic 'Invalid email or password' for both 'no such
user' and 'wrong password' to avoid email enumeration.
To let legitimate users recover accounts created by the bug, add a
/claim endpoint and page that only succeeds when passwordHash is null,
and add scripts/audit-passwordless-users.ts to identify and (with
--delete) remove orphan rows that have no reports.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…counts
The /api/auth/login route was upserting users by email and issuing a session without ever checking the supplied password. Two problems:
Login now does a findUnique + bcrypt.compare against the stored hash, and returns a generic 'Invalid email or password' for both 'no such user' and 'wrong password' to avoid email enumeration.
To let legitimate users recover accounts created by the bug, add a /claim endpoint and page that only succeeds when passwordHash is null, and add scripts/audit-passwordless-users.ts to identify and (with --delete) remove orphan rows that have no reports.