Nipype integration of NIFTI_NORDIC#21
Open
MoniDoerig wants to merge 13 commits into
Open
Conversation
Renamed function, adapted arguments and added additonal code for integration with a Nipype interface
Notebook showing example usage of using the Nipype interface and TSNR maps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request introduces modifications to the 'NIFTI_NORDIC.m' script to integrate it with a Nipype workflow, which necessitates new code to handle interactions with Python-generated '.mat' files.
Compatibility Note
The updated script is no longer compatible with the original standalone MATLAB usage, which relies on a MATLAB structure (ARG) as an (optional) input. The new version requires a Python-generated .mat file for its operation, which however is also optional.
Changes
NIFTI_NRODIC.mto support the integration with Nipype:NIFTI_NORDIC_nipype.m, which also reflects the renaming of the associated function within the script.Added a new Python module NiftiNordic in
NIFTI_NORDIC_interface.pyto wrap theNIFTI_NORDIC_nipype.mscript for Nipype compatibility.Included
example_usage_NORDIC_nipype.ipynb, a Jupyter Notebook that demonstrates how to use the new Nipype interface with fMRI data and compute TSNR maps.Proposal
Given that these changes alter the functionality of the original script, I propose that they be merged into a new branch (e.g.,
nipype-integration) rather than themainbranch. This would allow users who work with Nipype to benefit from these modifications without disrupting the original functionality of theNORDIC_rawrepository.Please review and let me know if any adjustments are needed.