Project 1 Feedback

[jadencarver]

Hey Steph,

I'm finally getting around to Project 1 Feedback, and here are my observations:

• Looking over your HTML, you have some mild formatting problems. Your .chips table rows (<tr> tags) aren't enclosing the <td> tags. It should follow the code: <table><tr><td></td></tr></table>.
• Your .scoreboard table has similar problems, missing <tr> tags around the <th> tags.
• Your CSS looks great, though I am curious why you used IDs for #heart, #spade, #club, #diamond instead of using classes, which would seem to make more sense. (whenever you have more than 1 of something, don't use an ID)
• Great job using @media queries!
• As for your JS - my first concern is that you are leaking into the global scope. You should wrap the JS code inside a closure, otherwise other programs might mess with your variables and cause unexpected issues.
• Great job using SVG!
• Some of your indentation in dealerScore() is off.

Great work!