Make the reconciliation job compare DB vs on-chain truth using escrow-invariants and mapping

[greatest0fallt1me]

Description

app/api/internal/reconciliation/route.ts only tallies stream-status counts; it never compares stored balances against on-chain state, even though lib/onChainClient.ts, lib/dbClient.ts, escrow-invariants.ts, and mapping.ts exist precisely for that (note lib/onChainClient.ts has an intentional released_amount mismatch for stream_2). Implement a real nightly reconciliation that detects drift. This is a backend on-chain reconciliation feature.

Requirements and Context

• For each stream, fetch on-chain state via lib/onChainClient.ts, DB state via lib/dbClient.ts, map fields using mapping.ts, and assert escrow-invariants.ts (balances never negative, released ≤ total).
• Report a structured discrepancies[] list (streamId, field, dbValue, onChainValue) in the response and persist a run record via dbClient.updateLastRunStatus.
• Honor the existing dryRun flag and internal-service auth.
• Must be secure, tested, and documented
• Should be efficient and easy to review

Suggested Execution

1. Fork the repo and create a branch

   git checkout -b feature/reconciliation-drift-detection

2. Implement changes
   • app/api/internal/reconciliation/route.ts
   • lib/onChainClient.ts, lib/dbClient.ts, mapping.ts, escrow-invariants.ts (wire together)
   • scripts/reconcile-streams.ts — invoke via npm run reconcile
3. Test and commit
   • npm test -- app/api/internal/reconciliation/route.test.ts
   • Cover edge cases: the seeded stream_2 mismatch, missing on-chain record, dryRun
   • Include test output and notes in the PR

Example commit message

feat: detect DB vs on-chain balance drift in reconciliation

Acceptance Criteria

• Response includes a discrepancies[] array for mismatched streams
• Seeded stream_2 mismatch is detected
• Escrow invariants asserted; negative/over-release flagged
• Coverage ≥ 90% for the reconciliation route and libs

Guidelines

• Minimum 90% test coverage including drift and missing-record cases
• Clear documentation and inline comments
• Timeframe: 96 hours

[itzabdoull]

@itzabdoull has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hi team, can i work on this issues?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @itzabdoull to this issue.

[drips-wave]

Congratulations, @itzabdoull! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @itzabdoull: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊