Warning in TEIP5-Test-dev

[martindholmes]

This has come up right before the 4.9.0 release, so I'm flagging it here rather than trying to fix it directly during the freeze:

Line 465 of extract-isosch.xsl issues a warning whenever a <sch:report> or <sch:assert> is a direct child of a <constraint> element. This warning is triggered by the following constraintSpec:

<constraintSpec ident="test_contextless_report" scheme="schematron" xml:lang="en">
              <desc>This <gi>constraintSpec</gi> is invalid because it
              has an <gi>sch:report</gi> that does not have a context
              (i.e., does not have a <tag>sch:rule
              context="…"</tag>.)</desc>
              <constraint>
                <sch:report test="false()">This rule never fires.</sch:report>
              </constraint>
            </constraintSpec>

This causes the warning to go into the build log and therefore the Jenkins build is tagged as unstable. Since this is a detest process, perhaps it's important that the warning message be triggered, but surely it should be captured in the detest.log and checked rather than output to the console. Not sure exactly what the solution should be here.

[martindholmes]

Digging into this:

Stylesheets/odds/extract-isosch.xsl has the following template:

  <xsl:template match="tei:constraint[ ../@scheme eq 'schematron' ]/(sch:report|sch:assert)">
    <xsl:message select="'WARNING: Ignoring invalid '||name(.)||' found directly within &lt;constraint>.'"/>
  </xsl:template>

which correctly issues a warning that a <sch:report> or a <sch:assert> will be ignored if it is directly inside a <constraint> element; we now require a wrapping <sch:rule> with @context. However, our P5/Test/detest.odd file contains the following three <constraintSpec>s:

<constraintSpec ident="add_missing_scheme" xml:lang="en">
              <desc>This <gi>constraintSpec</gi> is invalid because it is
              missing <att>scheme</att> in <val>add</val> mode.</desc>
              <constraint>
                <sch:report test="false()">This rule never fires, 01</sch:report>
              </constraint>
            </constraintSpec>
            <constraintSpec ident="replace_missing_scheme" mode="replace" xml:lang="en">
              <desc>This <gi>constraintSpec</gi> is invalid because it is
              missing <att>scheme</att> in <val>replace</val> mode.</desc>
              <constraint>
                <sch:report test="false()">This rule never fires, 02.</sch:report>
              </constraint>
            </constraintSpec>
            <constraintSpec ident="test_contextless_report" scheme="schematron" xml:lang="en">
              <desc>This <gi>constraintSpec</gi> is invalid because it
              has an <gi>sch:report</gi> that does not have a context
              (i.e., does not have a <tag>sch:rule
              context="…"</tag>.)</desc>
              <constraint>
                <sch:report test="false()">This rule never fires, 03.</sch:report>
              </constraint>
            </constraintSpec>

I believe the first two tests do not trigger, nor do they cause warnings to be issued, but I think the third does trigger a warning:

[xslt] WARNING: Ignoring invalid sch:report found directly within <constraint>.

I'm not sure if this is the behaviour we expect; the Jenkins log parser is configured to ignore this warning, meaning that the Test build does not get marked as unstable, but that means that if we had a genuine error that triggered this warning, the build would ignore it.

Shout out to @sydb and @HelenaSabel to get some input here: is this working as intended (or as close as we can get to optimally), in which case this ticket can be closed, or is some action required?