Wire orphaned test modules (deposit, release, refund, create_contract) into mod test

[mikewheeleer]

Description

contracts/escrow/src/test/mod.rs only declares emergency_controls and pause_controls, so cargo test runs just 31 tests. The test files deposit.rs, release.rs, refund.rs, and create_contract.rs at the crate root reference functions like refund_unreleased_milestones and get_milestones with outdated signatures and are never compiled. Reconcile and wire these suites into the test module.

Requirements and context

• Scoped to TalentTrust escrow Soroban contract (contracts/escrow).
• Move/align the orphaned suites under contracts/escrow/src/test/ and declare them in mod.rs; update signatures to match the current EscrowClient API.
• Fix calls such as release_milestone(&id, &0) to match the authorized signature introduced by the auth hardening work.
• Acceptance: cargo test discovers and passes the migrated suites; no orphaned .rs test files remain at the crate root.
• Must be secure, tested, and documented.

Suggested execution

• Fork the repo and create a branch:
  • git checkout -b test/wire-orphaned-suites
• Implement changes:
  • contracts/escrow/src/test/mod.rs
  • Tests: contracts/escrow/src/test/deposit.rs
  • Docs: docs/escrow/tests.md
  • Include rustdoc/NatSpec-style doc comments on public functions
  • Validate security assumptions (auth, overflow, fail-closed state machine, storage TTL, fee accounting)

Test and commit

• Run tests: cargo test
• Cover edge cases (unauthorized callers, double release/refund, expired approvals, fee rounding, paused state)
• Include test output and security notes in the PR

Example commit message

test(escrow): wire orphaned deposit/release/refund suites

Guidelines

• Minimum 95% test coverage on new/changed code
• Clear documentation
• Timeframe: 96 hours from assignment

[Harbduls]

@Harbduls has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Please allow me to work on this
I am a software engineer I can fix this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Harbduls to this issue.

[drips-wave]

Congratulations, @Harbduls! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @Harbduls: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊