Render: Make registration optional, stop throwing a warning if rendering a field/element that isn't registered

Author: nicolas-jaussaud

elements/index.php

@@ -57,9 +57,6 @@
 ) use($fields) : string {
 
   if ( ! $field = $fields->get_element( $name ) ) {
-    $caller = current( debug_backtrace() );
-    trigger_error("Element {$name} is not registered, called from <b>{$caller['file']}</b> in <b>{$caller['line']}</b>. Permissions, storage, validation callbacks are inert.", E_USER_WARNING);
-
     $fields->register_element( $name, $args );
     return $fields->render_element( $name );
   }

example/templates/registration/usage.md

@@ -1,7 +1,5 @@
 #### Description
 
-Registration is required if you render your field from `php`.
-
 To register a field, the `$fields->register_field()` function is used. It takes 2 arguments:
 - The field name
 - An array with the configuration of the field that can contain: 
@@ -20,5 +18,3 @@ echo $fields->render_field('field-name');
 ```
 
 More information on the save/load configuration in the next page.
-
-

fields/index.php

@@ -57,9 +57,6 @@
 ) use($fields) : string {
 
   if ( ! $field = $fields->get_field( $name ) ) {
-    $caller = current( debug_backtrace() );
-    trigger_error("Field {$name} is not registered, called from <b>{$caller['file']}</b> in <b>{$caller['line']}</b>. Permissions, storage, validation callbacks are inert.", E_USER_WARNING);
-
     $fields->register_field( $name, $args );
     return $fields->render_field( $name );
   }

tests/phpunit/cases/elements/render.php

@@ -59,21 +59,10 @@ public function test_elements_render_enqueues_element() {
   }
 
   public function test_elements_render_compat() {
-    $errored = null;
-    set_error_handler(function($errno, $errstr, ...$args) use (&$errored) {
-      $errored = [$errno, $errstr, $args];
-      restore_error_handler();
-    });
-
     $html = tangible_fields()->render_element('test', [
       'type' => 'button',
     ]);
 
-    $this->assertNotNull($errored, 'calling render_element without register_element did not trigger a warning');
-    [$errno, $errstr, $args] = $errored;
-
-    $this->assertEquals(E_USER_WARNING, $errno, 'calling render_element without register_element did not trigger an E_USER_WARNING');
-
     preg_match('#tangible-element-test-[^"]+#', $html, $matches);
     [$element] = $matches;
 

tests/phpunit/cases/fields/render.php

@@ -33,21 +33,11 @@ public function test_fields_render_enqueues_field() {
   }
 
   public function test_fields_render_compat() {
-    $errored = null;
-    set_error_handler(function($errno, $errstr, ...$args) use (&$errored) {
-      $errored = [$errno, $errstr, $args];
-      restore_error_handler();
-    });
 
     $html = tangible_fields()->render_field('test', [
       'type' => 'switch',
     ]);
 
-    $this->assertNotNull($errored, 'calling render_field without register_field did not trigger a warning');
-    [$errno, $errstr, $args] = $errored;
-
-    $this->assertEquals(E_USER_WARNING, $errno, 'calling render_field without register_field did not trigger an E_USER_WARNING');
-
     preg_match('#tangible-field-test-[^"]+#', $html, $matches);
     [$element] = $matches;