File names with spaces do not open in version 1.4.1

[MichaelJohnSmith]

File with names like "/images/test%20space.pdf" open without problem in version 1.4.0 but fail to open in 1.4.1
I am using Joomla version 5.4.2 and php 8.2

On investigation, the problem seems to be caused by code added to app.js in the function run(config) at lines 733-777

      try {
        file = new URL(decodeURIComponent(file)).href;
      } catch {
        file = encodeURIComponent(file).replaceAll("%2F", "/");
      }

When presented with a file variable containing the string "/images/test%20space.pdf" the URL constructor fails with the following error - URL constructor: /images/test space.pdf is not a valid URL.

The catch code converts the file name to "/images/test%2520space.pdf", resulting in the error

Missing PDF file.
PDF.js v5.4.149 (build: 9e2e9e209)
Message: Unexpected server response (404)
while retrieving PDF "https:// ... /images/test%2520space.pdf".

If the code block above is commented out, the file does open successfully.

[Tazzios]

I use the default from mozilla github.

It seems the latest version also has some changes, does that works?

https://github.com/mozilla/pdf.js/blob/07a4aab24675b622b216c4ac4add80e36c4e9767/web/app.js#L795

[MichaelJohnSmith]

I tried the change of removing the decodeURIComponent function, but it still failed (the URL constructor reports file name "test%20space" rather than "test space")

I then realised the constructor is actually looking for a full URL, not the relative one provided. I went back to my pdfviewer call and added the domain to the file name. This worked fine, both with the original 1.4.1 code, and with my recent change referred to above.

So, file names with spaces can be used if you specify the full URL, but not if you use a relative URL. Without spaces, either can be used.

So, that does give me a workaround - add the domain URL to all pdfviewer calls. In my particular application, I construct the call using php code, so it will be straight forward to implement this.

In order to be consistent with previous versions of PDFViewer, I think you will need to add the domain to any relative URLs before calling the pdf.js code.

[Tazzios]

Thanks for finding the solution, i`ll will update it in the next release.