[TagVal] Change serial number from integer to string

Author: vzahradnik

tcmenu/remote/commands/command_factory.py

@@ -54,7 +54,7 @@ class CommandFactory:
 
     @staticmethod
     def new_join_command(
-        name: str, uuid: Optional[UUID] = None, serial_number: Optional[int] = None
+        name: str, uuid: Optional[UUID] = None, serial_number: Optional[str] = None
     ) -> MenuJoinCommand:
         """
         Create a new join command. You can either provide a fixed UUID

tcmenu/remote/commands/menu_join_command.py

@@ -17,7 +17,7 @@ class MenuJoinCommand(MenuCommand):
 
     app_uuid: uuid.UUID = uuid.uuid4()
 
-    serial_number: int = 999999999
+    serial_number: str = "999999999"
 
     @property
     def command_type(self) -> MessageField:

test/remote/commands/test_menu_join_command.py

@@ -14,7 +14,7 @@ def test_menu_join_command_random_uuid():
     assert command.my_name == "Android Phone"
     assert type(command.api_version) == int
     assert command.platform == ApiPlatform.PYTHON_API
-    assert command.serial_number == 999999999
+    assert command.serial_number == "999999999"
 
 
 def test_menu_join_command_fixed_uuid():
@@ -28,16 +28,16 @@ def test_menu_join_command_fixed_uuid():
     assert command.my_name == "Android Phone"
     assert type(command.api_version) == int
     assert command.platform == ApiPlatform.PYTHON_API
-    assert command.serial_number == 999999999
+    assert command.serial_number == "999999999"
 
 
 def test_menu_join_command_custom_serial_number():
-    command = CommandFactory.new_join_command(name="Android Phone", serial_number=55441233)
+    command = CommandFactory.new_join_command(name="Android Phone", serial_number="55441233")
     assert isinstance(command.app_uuid, uuid.UUID)
     assert isinstance(command.command_type, MessageField) is True
     assert command.command_type.id == "NJ"
 
     assert command.my_name == "Android Phone"
     assert type(command.api_version) == int
     assert command.platform == ApiPlatform.PYTHON_API
-    assert command.serial_number == 55441233
+    assert command.serial_number == "55441233"