From 70ceed2cf84821742c2c4a494aee587f6e03db8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Harboe?= Date: Sat, 5 Sep 2026 08:28:10 +0200 Subject: [PATCH] designs: mempool_group/rtl BUILD uses files() so its sources export individually MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit nangate45/mempool_group's VERILOG_FILES names the files under src/mempool_group/rtl one by one. bazel-orfs's config.mk parser turns each into a per-file label, and a bare filegroup over a glob makes those files private to this package, so the design fails analysis under bazel with a visibility error on every one of them. files("include", extra_srcs = ...) is the same filegroup -- the same glob plus the same five sibling-package headers -- and also exports each source as its own label. No change to what the include group contains. Co-Authored-By: Claude Fable 5.1 Signed-off-by: Øyvind Harboe --- flow/designs/src/mempool_group/rtl/BUILD | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/flow/designs/src/mempool_group/rtl/BUILD b/flow/designs/src/mempool_group/rtl/BUILD index c9161cd38e..d43f51f4cf 100644 --- a/flow/designs/src/mempool_group/rtl/BUILD +++ b/flow/designs/src/mempool_group/rtl/BUILD @@ -1,11 +1,18 @@ -filegroup( - name = "include", - srcs = glob(["*.v", "*.sv", "*.svh"], allow_empty = True) + [ +load("//flow/designs:design.bzl", "files") + +# files() rather than a bare filegroup: the globbed sources are then also +# exported as individual labels, which the config.mk parser in bazel-orfs +# needs -- nangate45/mempool_group's VERILOG_FILES names files in this +# directory one by one, and a bare filegroup makes them private to it. +# The extra sources are the headers from sibling packages that the +# include group has always carried. +files( + "include", + extra_srcs = [ "//flow/designs/src/mempool_group/rtl/axi:assign.svh", "//flow/designs/src/mempool_group/rtl/axi:typedef.svh", "//flow/designs/src/mempool_group/rtl/common_cells:assertions.svh", "//flow/designs/src/mempool_group/rtl/common_cells:registers.svh", "//flow/designs/src/mempool_group/rtl/mempool:mempool.svh", ], - visibility = ["//visibility:public"], )