Potential fix for pull request finding

improve option value handling.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Michael Adam <obnox@samba.org>

Author: obnoxxx

cli/builbo

@@ -111,21 +111,69 @@ echo " processing command line arguments.."
 rewrite_args=()
 while [ $# -gt 0 ]; do
   case "$1" in
-    --lang)             rewrite_args+=("-l" "$2"); shift 2 ;;
+    --lang)
+      if [ $# -lt 2 ] || [[ "$2" == -* ]]; then
+        echo "error: option '$1' requires a value." >&2
+        usage
+        exit 1
+      fi
+      rewrite_args+=("-l" "$2"); shift 2 ;;
     --lang=*)           rewrite_args+=("-l" "${1#*=}"); shift ;;
-    --registry)         rewrite_args+=("-r" "$2"); shift 2 ;;
+    --registry)
+      if [ $# -lt 2 ] || [[ "$2" == -* ]]; then
+        echo "error: option '$1' requires a value." >&2
+        usage
+        exit 1
+      fi
+      rewrite_args+=("-r" "$2"); shift 2 ;;
     --registry=*)       rewrite_args+=("-r" "${1#*=}"); shift ;;
-    --container-cmd)    rewrite_args+=("-c" "$2"); shift 2 ;;
+    --container-cmd)
+      if [ $# -lt 2 ] || [[ "$2" == -* ]]; then
+        echo "error: option '$1' requires a value." >&2
+        usage
+        exit 1
+      fi
+      rewrite_args+=("-c" "$2"); shift 2 ;;
     --container-cmd=*)  rewrite_args+=("-c" "${1#*=}"); shift ;;
-    --os)               rewrite_args+=("-o" "$2"); shift 2 ;;
+    --os)
+      if [ $# -lt 2 ] || [[ "$2" == -* ]]; then
+        echo "error: option '$1' requires a value." >&2
+        usage
+        exit 1
+      fi
+      rewrite_args+=("-o" "$2"); shift 2 ;;
     --os=*)             rewrite_args+=("-o" "${1#*=}"); shift ;;
-    --registry-namespace)   rewrite_args+=("-n" "$2"); shift 2 ;;
+    --registry-namespace)
+      if [ $# -lt 2 ] || [[ "$2" == -* ]]; then
+        echo "error: option '$1' requires a value." >&2
+        usage
+        exit 1
+      fi
+      rewrite_args+=("-n" "$2"); shift 2 ;;
     --registry-namespace=*) rewrite_args+=("-n" "${1#*=}"); shift ;;
-    --build-script)     rewrite_args+=("-s" "$2"); shift 2 ;;
+    --build-script)
+      if [ $# -lt 2 ] || [[ "$2" == -* ]]; then
+        echo "error: option '$1' requires a value." >&2
+        usage
+        exit 1
+      fi
+      rewrite_args+=("-s" "$2"); shift 2 ;;
     --build-script=*)   rewrite_args+=("-s" "${1#*=}"); shift ;;
-    --deps)             rewrite_args+=("-d" "$2"); shift 2 ;;
+    --deps)
+      if [ $# -lt 2 ] || [[ "$2" == -* ]]; then
+        echo "error: option '$1' requires a value." >&2
+        usage
+        exit 1
+      fi
+      rewrite_args+=("-d" "$2"); shift 2 ;;
     --deps=*)           rewrite_args+=("-d" "${1#*=}"); shift ;;
-    --shell)            rewrite_args+=("-i" "$2"); shift 2 ;;
+    --shell)
+      if [ $# -lt 2 ] || [[ "$2" == -* ]]; then
+        echo "error: option '$1' requires a value." >&2
+        usage
+        exit 1
+      fi
+      rewrite_args+=("-i" "$2"); shift 2 ;;
     --shell=*)          rewrite_args+=("-i" "${1#*=}"); shift ;;
     --help)             rewrite_args+=("-h"); shift ;;
     --test)             rewrite_args+=("-t"); shift ;;