Skip to content

Drone ability is also added to parent unit #3

@ThePants999

Description

@ThePants999

If you take a T'au unit and add gun drones to it, the Threat Identification Protocols ability that's specific to the drones is replicated on the parent unit.

The roster data is entirely sensible and has the ability as a Profile of type Abilities below the gun drone Selection. However, the code in Unit.js, when it finds the gun drone Selection, creates it as a model using:

addModelSimpleData(selectionData.$.name, selectionData.selections, selectionData.$.number)

In other words, it's passing in the name and number of this model, and the child Selections. That works for weaponry, which is a Selection underneath, but the ability is a Profile underneath, so although Model.js has code to handle child Profiles, it never sees them in this instance.

Too low-impact for me to fix right now, but might be an interesting starter issue for someone looking to get to grips with the code. There's a test case that catches this (although it currently passes because it just accepts the issue).

Metadata

Metadata

Assignees

No one assigned

    Labels

    9eThis issue relates to 9th edition, and probably won't be fixed nowbattlescribeSpecific to BattlescribebugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions