Skip to content

refactor: Add override/final keywords to virtual functions with VC6 compatibility #6251

refactor: Add override/final keywords to virtual functions with VC6 compatibility

refactor: Add override/final keywords to virtual functions with VC6 compatibility #6251

Triggered via pull request March 9, 2026 21:34
Status Success
Total duration 10m 57s
Artifacts 20

ci.yml

on: pull_request
Detect File Changes
11s
Detect File Changes
Matrix: build-generalsmd-vc6
Matrix: build-generals
Matrix: build-generalsmd-win32
Matrix: replaycheck-generalsmd
Fit to window
Zoom out
Zoom in

Annotations

190 warnings
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-vcpkg-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-vcpkg-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWLib/thread.cpp#L19
'_WIN32_WINNT': macro redefinition
Build GeneralsMD / win32-vcpkg+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWLib/thread.cpp#L19
'_WIN32_WINNT': macro redefinition
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-vcpkg+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning

Artifacts

Produced during runtime
Name Size Digest
Generals-vc6+t+e Expired
16.1 MB
sha256:ba5b8adc4dd93bc5e521361c457ab687311f874358b2226bc249e932fffe0363
Generals-vc6-debug+t+e Expired
52.1 MB
sha256:913fcdb77f1e39be4c5367647d5734238b8d78dadd25cf78764eef3aa18b56c3
Generals-vc6-profile+t+e Expired
16.1 MB
sha256:e77b31b1c72b0d61ce12ba7ff389f46fd1e476c1a4f821b991f99cc4ee23b6e0
Generals-win32+t+e Expired
85.5 MB
sha256:7fba9bb5ee0e8e09240133c73969dce5e13a5d477466f98848a2dcb08b89979b
Generals-win32-debug+t+e Expired
204 MB
sha256:aed326ee514e9c13b40e2ef19fdc877c228a82d8bbd5fb5290a4b23abe58710a
Generals-win32-profile+t+e Expired
85.7 MB
sha256:c9787a2d05dd0e61ca194f28b181fe9aebaceb21d8adbd03cd9c1cd5b7bffa1c
Generals-win32-vcpkg+t+e Expired
85.6 MB
sha256:1dae8de96a05652f743e2d6b4b7366298cba7839a38561a9b461941596223da4
Generals-win32-vcpkg-debug+t+e Expired
204 MB
sha256:882c1de8328e681166937f3b88c4c1ece04efe45f931c0aa2892c367e1fc1ac4
Generals-win32-vcpkg-profile+t+e Expired
85.3 MB
sha256:648db38a07d37e131f59416c81d57bc82fa12676fe50f44fd2a2d34f56aa9363
GeneralsMD-vc6+t+e Expired
17.1 MB
sha256:8ae3856cb176d3cc203350df9eb6ecffc30989cc854c902a5cd661ed0cb18573
GeneralsMD-vc6-debug+t+e Expired
54.5 MB
sha256:e1d6bb3aacbaabe503828fca7fd6ca506002eb8e5334ec0f7644102eb341fa38
GeneralsMD-vc6-profile+t+e Expired
17.3 MB
sha256:02155065356b2590130f9860a558e22ec9023e3d8ce0edaed163ea617ac6b3e5
GeneralsMD-vc6-releaselog+t+e Expired
30.4 MB
sha256:cf1c3d6f78ddab52e87177296050996f4e969b0e82dc90aa4ddd2ae412746d92
GeneralsMD-win32+t+e Expired
89.9 MB
sha256:3037b9fbe05c17ddc285056c8474d8ecbe6c9b009ada9177d9c1443e4e525dd7
GeneralsMD-win32-debug+t+e Expired
212 MB
sha256:4211b5354381f7998c7ecb5af602236e7991aec8b57f6cd3877a9c3d0a64cc5d
GeneralsMD-win32-profile+t+e Expired
90.4 MB
sha256:6d185e8786a8e22e83bbffc02c75c9e499c5f6948dd2ab42c43ba913fd3a96cf
GeneralsMD-win32-vcpkg+t+e Expired
90.1 MB
sha256:48455b5934e97b91993e4d17b0ad9e6472b05bf80ebb10ce6460e74142d074b1
GeneralsMD-win32-vcpkg-debug+t+e Expired
212 MB
sha256:6504b0bf148261e8819536096cc02bfd7c71441f43e6d1857bb643ba2d286bac
GeneralsMD-win32-vcpkg-profile+t+e Expired
90.4 MB
sha256:a7cf2d7a9d31e414de34ec0d463558e9c5359d46942e4d7bb3c783691f473699
Replay-Debug-Log-vc6-releaselog+t+e Expired
3.12 MB
sha256:47769a90f4f2ef3020f5b271289675da96487ab66b2ce05e8ed3da01facfac10