fix(shadow): Fix crash by initializing debris shadow name to an empty string (#2221)

Author: Stubbjax

Core/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DDebrisDraw.cpp

@@ -129,8 +129,6 @@ void W3DDebrisDraw::setModelName(AsciiString name, Color color, ShadowType t)
 		{
 			Shadow::ShadowTypeInfo shadowInfo;
 			shadowInfo.m_type = t;
-			shadowInfo.m_sizeX=0;
-			shadowInfo.m_sizeY=0;
   		m_shadow = TheW3DShadowManager->addShadow(m_renderObject, &shadowInfo);
 		}
 		else

Core/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DDefaultDraw.cpp

@@ -62,10 +62,6 @@ W3DDefaultDraw::W3DDefaultDraw(Thing *thing, const ModuleData* moduleData) : Dra
 
 		Shadow::ShadowTypeInfo shadowInfo;
 		shadowInfo.m_type=(ShadowType)SHADOW_VOLUME;
-		shadowInfo.m_sizeX=0;	//use defaults
-		shadowInfo.m_sizeY=0;
-		shadowInfo.m_offsetX=0;
-		shadowInfo.m_offsetY=0;
   		m_shadow = TheW3DShadowManager->addShadow(m_renderObject, &shadowInfo);
 
 

Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DTreeBuffer.cpp

@@ -697,14 +697,11 @@ void W3DTreeBuffer::loadTreesInVertexAndIndexBuffers(RefRenderObjListIterator *p
 
 	if (m_shadow == nullptr && TheW3DProjectedShadowManager) {
 		Shadow::ShadowTypeInfo shadowInfo;
-		shadowInfo.m_ShadowName[0] = 0;
 		shadowInfo.allowUpdates=FALSE;	//shadow image will never update
 		shadowInfo.allowWorldAlign=TRUE;	//shadow image will wrap around world objects
 		shadowInfo.m_type = (ShadowType)SHADOW_DECAL;
 		shadowInfo.m_sizeX=20;
 		shadowInfo.m_sizeY=20;
-		shadowInfo.m_offsetX=0;
-		shadowInfo.m_offsetY=0;
 		m_shadow = TheW3DProjectedShadowManager->createDecalShadow(&shadowInfo);
 	}
 

Generals/Code/GameEngine/Include/GameClient/Shadow.h

@@ -73,6 +73,18 @@ class Shadow
 
 		struct	ShadowTypeInfo
 		{
+				ShadowTypeInfo()
+				{
+						m_ShadowName[0] = '\0';
+						m_type = SHADOW_NONE;
+						allowUpdates = false;
+						allowWorldAlign = false;
+						m_sizeX = 0.0f;
+						m_sizeY = 0.0f;
+						m_offsetX = 0.0f;
+						m_offsetY = 0.0f;
+				}
+
 				char	m_ShadowName[64];	//when set, overrides the default model shadow (used mostly for Decals).
 				ShadowType m_type;			//type of shadow
 				Bool	allowUpdates;			//whether to update the shadow image when object/light moves.

GeneralsMD/Code/GameEngine/Include/GameClient/Shadow.h

@@ -73,6 +73,18 @@ class Shadow
 
 		struct	ShadowTypeInfo
 		{
+				ShadowTypeInfo()
+				{
+						m_ShadowName[0] = '\0';
+						m_type = SHADOW_NONE;
+						allowUpdates = false;
+						allowWorldAlign = false;
+						m_sizeX = 0.0f;
+						m_sizeY = 0.0f;
+						m_offsetX = 0.0f;
+						m_offsetY = 0.0f;
+				}
+
 				char	m_ShadowName[64];	//when set, overrides the default model shadow (used mostly for Decals).
 				ShadowType m_type;			//type of shadow
 				Bool	allowUpdates;			//whether to update the shadow image when object/light moves.