Destroyed oils sometimes not rendering correctly in replays

[helmutbuhler]

I noticed some issues with displaying oils that have been destroyed:



Unfortunately it's very random when the oil appears like this. I never noticed this in retail, I think it's likely this PR #1569 causes this.

In some situations it also shows the oil as ok:

Even though in this case the player should see it as destroyed (the player destroyed it in this case). I can upload the replay where I took these screenshots, but it seems replay-independent.

Here is the replay I used for the screenshots:
replay_oil.zip
The right player kills the left oil at around 5 minutes. What I did for the last screenshot is to load the replay, select right player, move camera so that the left oil is not visible, fast forward to around 6 minutes and look at the left oil. But the bug rarely happens, it's not deterministic.

[Stubbjax]

Was this issue observed on xezon:xezon/impl-player-observer or main? Issue reports should be reserved for observations made in the retail game or builds of the main branch.

[helmutbuhler]

That branch of xezon was merged where I observed this. You can close this issue if this is not the right place.

[xezon]

Not yet merged. Issue report is ok for me.

[xezon]

The worst I was able to reproduce is this:

[xezon]

Appears not related to W3DGhostObjectManager::updateOrphanedObjects

[xezon]

I dont understand what the repro of the issue is.

[helmutbuhler]

Thanks for trying to investigate!
Sadly I cannot reproduce it now either. I used the same commit as originally, just recompiled, but it won't reproduce after quite a few attempts. Really strange... Possibly a compiler bug?
I'll let you know if I stumble upon this again.