Skip to content

Review all exception throws and demote them to asserts where appropriate #857

Description

@xezon

Throwing exceptions for non critical things is not good. It stops the runtime unnecessarily. It would be better to raise asserts and return the offending code paths. This gives the runtime the chance to just move on. This is better for the user when the error is not catastrophic.

An example of an unnecessary throw is

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    MajorSeverity: Minor < Major < Critical < BlockerRefactorEdits the code with insignificant behavior changes, is never user facingStabilityConcerns stability of the runtime

    Type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions