diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e8a35065b..1ce8cbe8c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,40 +1,40 @@ name: Continuous Integration on: - pull_request: + pull_request: - # Allow job to be manually started - workflow_dispatch: + # Allow job to be manually started + workflow_dispatch: jobs: - lint: - name: Lint - runs-on: ubuntu-latest - timeout-minutes: 5 - steps: - - uses: actions/checkout@v2 - - - uses: actions/setup-node@v2 - with: - node-version: '18' - - - uses: actions/cache@v4 - id: cache-node-modules - with: - key: ${{ runner.os }}-node18-modules-${{ hashFiles('**/package-lock.json') }} - restore-keys: ${{ runner.os }}-node18-modules- - path: | - apps/frontend/node_modules - - - name: Install dependencies - if: steps.cache-node-modules.outputs.cache-hit != 'true' - working-directory: apps/frontend/ - run: npm i --no-audit --no-fund - - - name: ESLint - working-directory: apps/frontend/ - run: npm run lint - - - name: Svelte Check - working-directory: apps/frontend/ - run: npm run check + lint: + name: Lint + runs-on: ubuntu-latest + timeout-minutes: 5 + steps: + - uses: actions/checkout@v2 + + - uses: actions/setup-node@v2 + with: + node-version: "22" + + - uses: actions/cache@v4 + id: cache-node-modules + with: + key: ${{ runner.os }}-node22-modules-${{ hashFiles('**/package-lock.json') }} + restore-keys: ${{ runner.os }}-node22-modules- + path: | + apps/frontend/node_modules + + - name: Install dependencies + if: steps.cache-node-modules.outputs.cache-hit != 'true' + working-directory: apps/frontend/ + run: npm i --no-audit --no-fund + + - name: ESLint + working-directory: apps/frontend/ + run: npm run lint + + - name: Svelte Check + working-directory: apps/frontend/ + run: npm run check diff --git a/apps/frontend/components/achievements/CriteriaTree.svelte b/apps/frontend/components/achievements/CriteriaTree.svelte index 7d6a340a9..102eb259f 100644 --- a/apps/frontend/components/achievements/CriteriaTree.svelte +++ b/apps/frontend/components/achievements/CriteriaTree.svelte @@ -43,7 +43,7 @@ criteriaCharacters?.[criteriaTree?.criteriaId || -1]?.[0]?.[1] || 0; have = maxCharacter > 0 && maxCharacter >= criteriaTree.amount; } else { - let maybeCriteria: number[][] = []; + let maybeCriteria: number[][]; maybeCriteria = criteriaCharacters[criteria?.id] || [[0, 0]]; if (achievement.isAccountWide) { diff --git a/apps/frontend/components/characters/paperdoll/CharactersPaperdollConfigure.svelte b/apps/frontend/components/characters/paperdoll/CharactersPaperdollConfigure.svelte index a20a865c0..75e82ec6a 100644 --- a/apps/frontend/components/characters/paperdoll/CharactersPaperdollConfigure.svelte +++ b/apps/frontend/components/characters/paperdoll/CharactersPaperdollConfigure.svelte @@ -1,54 +1,53 @@