diff --git a/NAMESPACE b/NAMESPACE index 37bd5092..8fb1c8b8 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -21,11 +21,9 @@ export(add_positconnect_file) export(add_r6) export(add_resource_path) export(add_rscignore_file) -export(add_rstudioconnect_file) export(add_sass_file) export(add_shinyappsio_file) export(add_shinyserver_file) -export(add_ui_server_files) export(add_utils) export(amend_golem_config) export(app_dev) @@ -51,7 +49,6 @@ export(get_golem_name) export(get_golem_options) export(get_golem_version) export(get_golem_wd) -export(get_sysreqs) export(golem_welcome_page) export(install_dev_deps) export(invoke_js) @@ -87,7 +84,6 @@ export(use_internal_html_template) export(use_internal_js_file) export(use_module_test) export(use_readme_rmd) -export(use_recommended_deps) export(use_recommended_tests) export(use_utils_server) export(use_utils_test_server) diff --git a/NEWS.md b/NEWS.md index aabd894d..a12783c6 100644 --- a/NEWS.md +++ b/NEWS.md @@ -14,6 +14,14 @@ - `{golem}` functions used to rely on arguments that where either `wd`, `path`, `pkg` or `golem_wd`. This has now been standardized and all functions rely on `golem_wd` now (@ilyaZar, #845) +- `get_sysreqs()` has been removed; use `dockerfiler::get_sysreqs()` instead. + +- `use_recommended_deps()` has been removed. + +- `add_ui_server_files()` has been removed. + +- `add_rstudioconnect_file()` has been removed; use `add_positconnect_file()` instead. + - Creating a `golem` doesn't call `set_here()` nor `usethis::create_project()` anymore. It used to be because we wanted to be able to use `here::here()`, but the function should be able to find its way based using `DESCRIPTION`. It gives a lighter implementation of golem projects creation as it doesn't mess up with where `here()` is anymore. - The `add_*_files` and `use_*_files` now fail when: @@ -26,6 +34,14 @@ - `run_dev()` only prints one message (#1191 / @howardbaik) +## Soft deprecated + +- `browser_button()` is now soft deprecated (#1155) + +- `add_dockerfile()`, `add_dockerfile_shinyproxy()`, and + `add_dockerfile_heroku()` are now explicitly soft deprecated; use the + corresponding `add_dockerfile_with_renv_*()` functions. + ## Bug fix - Removing the comments on golem creation didn't work fully, this has been fixed. diff --git a/R/add_dockerfiles.R b/R/add_dockerfiles.R index 7a1ec440..589fd6a7 100644 --- a/R/add_dockerfiles.R +++ b/R/add_dockerfiles.R @@ -53,6 +53,10 @@ talk_once <- function( #' an updated tar.gz is created. #' @param extra_sysreqs character vector. Extra debian system requirements. #' +#' @note `add_dockerfile()`, `add_dockerfile_shinyproxy()`, and +#' `add_dockerfile_heroku()` are now soft deprecated; use the corresponding +#' `add_dockerfile_with_renv_*()` functions instead. +#' #' @export #' @rdname dockerfiles #' @@ -122,6 +126,10 @@ add_dockerfile <- function( ), "pkg" ) + .Deprecated( + old = "add_dockerfile", + msg = "add_dockerfile() is currently soft deprecated and will be removed in future versions of {golem}.\nPlease use add_dockerfile_with_renv() instead." + ) add_dockerfile_( path = path, output = output, @@ -257,6 +265,10 @@ add_dockerfile_shinyproxy <- function( ), "pkg" ) + .Deprecated( + old = "add_dockerfile_shinyproxy", + msg = "add_dockerfile_shinyproxy() is currently soft deprecated and will be removed in future versions of {golem}.\nPlease use add_dockerfile_with_renv_shinyproxy() instead." + ) add_dockerfile_shinyproxy_( path = path, output = output, @@ -382,6 +394,10 @@ add_dockerfile_heroku <- function( ), "pkg" ) + .Deprecated( + old = "add_dockerfile_heroku", + msg = "add_dockerfile_heroku() is currently soft deprecated and will be removed in future versions of {golem}.\nPlease use add_dockerfile_with_renv_heroku() instead." + ) add_dockerfile_heroku_( path = path, output = output, diff --git a/R/add_files.R b/R/add_files.R index 46c189e8..dd59a614 100644 --- a/R/add_files.R +++ b/R/add_files.R @@ -25,8 +25,6 @@ #' @importFrom attempt stop_if #' @importFrom utils file.edit #' -#' @note `add_ui_server_files` will be deprecated in future version of `{golem}` -#' #' @seealso \code{\link{js_template}}, \code{\link{js_handler_template}}, and \code{\link{css_template}} #' #' @return The path to the file, invisibly. @@ -911,121 +909,3 @@ add_partial_html_template <- function( open = open ) } - -#' @export -#' @rdname add_files -add_ui_server_files <- function( - golem_wd = get_golem_wd(), - dir = "inst/app", - dir_create, - pkg -) { - signal_arg_is_deprecated( - pkg, - fun = as.character( - sys.call()[[1]] - ), - "pkg" - ) - if ( - !missing( - dir_create - ) - ) { - cli_abort_dir_create() - } - .Deprecated( - msg = "This function will be deprecated in a future version of {golem}.\nPlease comment on https://github.com/ThinkR-open/golem/issues/445 if you want it to stay." - ) - - old <- setwd( - fs_path_abs( - golem_wd - ) - ) - on.exit( - setwd( - old - ) - ) - - dir <- fs_path_abs( - dir - ) - check_directory_exists( - dir - ) - - # UI - where <- fs_path( - dir, - "ui.R" - ) - - if ( - !fs_file_exists( - where - ) - ) { - fs_file_create( - where - ) - - write_there <- write_there_builder( - where - ) - - pkg <- get_golem_name() - - write_there( - sprintf( - "%s:::app_ui()", - pkg - ) - ) - - cat_created( - where, - "ui file" - ) - } else { - cli_alert_info( - "UI file already exists." - ) - } - - # server - where <- file.path( - dir, - "server.R" - ) - - if ( - !fs_file_exists( - where - ) - ) { - fs_file_create( - where - ) - - write_there <- write_there_builder( - where - ) - - write_there( - sprintf( - "%s:::app_server", - pkg - ) - ) - cat_created( - where, - "server file" - ) - } else { - cli_alert_info( - "Server file already exists." - ) - } -} diff --git a/R/add_rstudio_files.R b/R/add_rstudio_files.R index b1ae110b..08707392 100644 --- a/R/add_rstudio_files.R +++ b/R/add_rstudio_files.R @@ -150,7 +150,7 @@ add_rstudio_files <- function( #' #' #' @inheritParams add_module -#' @aliases add_rconnect_file add_rstudioconnect_file add_positconnect_file +#' @aliases add_rconnect_file add_positconnect_file #' @export #' #' @rdname rstudio_deploy @@ -190,30 +190,6 @@ add_positconnect_file <- function( ) } -#' @rdname rstudio_deploy -#' @note `add_rstudioconnect_file` is now deprecated; replace by [add_positconnect_file()]. -#' @export -add_rstudioconnect_file <- function( - golem_wd = get_golem_wd(), - open = TRUE, - pkg -) { - signal_arg_is_deprecated( - pkg, - fun = as.character( - sys.call()[[1]] - ), - "pkg" - ) - .Deprecated( - "add_positconnect_file" - ) - add_positconnect_file( - golem_wd = get_golem_wd(), - open = TRUE - ) -} - #' @rdname rstudio_deploy #' @export add_shinyappsio_file <- function( diff --git a/R/browser_button.R b/R/browser_button.R index 7e0fed71..e31a9b72 100644 --- a/R/browser_button.R +++ b/R/browser_button.R @@ -2,12 +2,19 @@ #' #' See \url{https://rtask.thinkr.fr/a-little-trick-for-debugging-shiny/} for more context. #' +#' @note `browser_button()` is now soft deprecated and will be removed in a +#' future version of `{golem}`. +#' #' @return Used for side effects. #' Prints the code to the console. #' @export #' browser_button <- function() { + .Deprecated( + old = "browser_button", + msg = "browser_button() is currently soft deprecated and will be removed in future versions of {golem}." + ) cli_cat_rule( "To be copied in your UI" ) diff --git a/R/desc.R b/R/desc.R index 9a99c881..3a064278 100644 --- a/R/desc.R +++ b/R/desc.R @@ -12,13 +12,13 @@ #' @param repo_url URL (if needed) #' @param pkg_version The version of the package. Default is 0.0.0.9000 #' @param pkg Path to look for the DESCRIPTION. Default is `get_golem_wd()`. -#' @param author_first_name to be deprecated: use character for first name via -#' `authors = person(given = "authors_first_name")` instead -#' @param author_last_name to be deprecated: use character for last name via -#' `authors = person(given = "authors_last_name")` instead -#' @param author_email to be deprecated: use character for first name via -#' `authors = person(email = "author_email")` instead -#' @param author_orcid to be deprecated +#' @param author_first_name Deprecated: use `authors = person(given = ...)` +#' instead +#' @param author_last_name Deprecated: use `authors = person(family = ...)` +#' instead +#' @param author_email Deprecated: use `authors = person(email = ...)` instead +#' @param author_orcid Deprecated: use `authors = person(comment = c(ORCID = ...))` +#' instead #' @param set_options logical; the default `TRUE` sets all recommended #' options but this can be suppressed with `FALSE`. For details on the #' exact behaviour see the help [set_golem_options()]. @@ -79,7 +79,7 @@ fill_desc <- function( if (!any_author_params_is_not_null) { warning( - "The `author_first_name`, `author_last_name`, `author_email` and `author_orcid` parameters will be deprecated from fill_desc() in the next version of {golem}. \nPlease use the `authors` parameter instead.\nSee ?person for more details on how to use it." + "The `author_first_name`, `author_last_name`, `author_email` and `author_orcid` parameters of `fill_desc()` are deprecated and will be removed in a future version of {golem}. \nPlease use the `authors` parameter instead.\nSee ?person for more details on how to use it." ) # Case 1.1 : old author params are null and authors is empty if ( diff --git a/R/get_sysreqs.R b/R/get_sysreqs.R deleted file mode 100644 index 47882867..00000000 --- a/R/get_sysreqs.R +++ /dev/null @@ -1,25 +0,0 @@ -# Now in `{dockerfiler}` - -#' Get system requirements (Deprecated) -#' -#' This function is now deprecated, and was moved to -#' `{dockerfiler}`. -#' -#' @param packages character vector. Packages names. -#' @param batch_n numeric. Number of simultaneous packages to ask. -#' @param quiet Boolean. If `TRUE` the function is quiet. -#' -#' -#' @export -#' -#' @return A vector of system requirements. -get_sysreqs <- function( - packages, - quiet = TRUE, - batch_n = 30 -) { - .Deprecated( - "dockerfiler::get_sysreqs", - msg = "get_sysreqs() is deprecated and has been moved to {dockerfiler}." - ) -} diff --git a/R/use_recommended.R b/R/use_recommended.R index 8abf234c..cba3c1bb 100644 --- a/R/use_recommended.R +++ b/R/use_recommended.R @@ -1,13 +1,7 @@ #' Add recommended elements #' -#' \describe{ -#' \item{use_recommended_deps}{Adds `shiny`, `DT`, `attempt`, `glue`, `golem`, `htmltools` to dependencies} -#' \item{use_recommended_tests}{Adds a test folder and copy the golem tests} -#' } -#' #' @inheritParams add_module #' @inheritParams usethis::use_spell_check -#' @param recommended A vector of recommended packages. #' @param spellcheck Whether or not to use a spellcheck test. #' #' @rdname use_recommended @@ -16,49 +10,6 @@ #' #' @return Used for side-effects. #' -use_recommended_deps <- function( - pkg = get_golem_wd(), - recommended = c( - "shiny", - "DT", - "attempt", - "glue", - "htmltools", - "golem" - ) -) { - .Deprecated( - old = "use_recommended_deps", - msg = "use_recommended_deps() is currently soft deprecated and will be removed in future versions of {golem}." - ) - - old <- setwd( - fs_path_abs( - pkg - ) - ) - on.exit( - setwd( - old - ) - ) - - for (i in sort( - recommended - )) { - try( - usethis_use_package( - i - ) - ) - } - - cli_alert_success( - "Dependencies added." - ) -} - - #' @rdname use_recommended #' @export #' @importFrom utils capture.output diff --git a/inst/mantests/build.R b/inst/mantests/build.R index 4b900f97..b167f504 100644 --- a/inst/mantests/build.R +++ b/inst/mantests/build.R @@ -304,8 +304,6 @@ expect_true( dir.exists("tests") ) -# golem::use_recommended_deps() - golem::use_utils_ui(with_test = TRUE) expect_true( file.exists("R/golem_utils_ui.R") diff --git a/man/add_files.Rd b/man/add_files.Rd index c75fed32..a2797cbd 100644 --- a/man/add_files.Rd +++ b/man/add_files.Rd @@ -10,7 +10,6 @@ \alias{add_empty_file} \alias{add_html_template} \alias{add_partial_html_template} -\alias{add_ui_server_files} \title{Create Files} \usage{ add_js_file( @@ -108,12 +107,6 @@ add_partial_html_template( pkg ) -add_ui_server_files( - golem_wd = get_golem_wd(), - dir = "inst/app", - dir_create, - pkg -) } \arguments{ \item{name}{The name of the module.} @@ -155,9 +148,6 @@ The path to the file, invisibly. \description{ These functions create files inside the \code{inst/app} folder. } -\note{ -\code{add_ui_server_files} will be deprecated in future version of \code{{golem}} -} \seealso{ \code{\link{js_template}}, \code{\link{js_handler_template}}, and \code{\link{css_template}} } diff --git a/man/browser_button.Rd b/man/browser_button.Rd index a0ab9247..4284a9bb 100644 --- a/man/browser_button.Rd +++ b/man/browser_button.Rd @@ -13,3 +13,7 @@ Prints the code to the console. \description{ See \url{https://rtask.thinkr.fr/a-little-trick-for-debugging-shiny/} for more context. } +\note{ +\code{browser_button()} is now soft deprecated and will be removed in a +future version of \code{{golem}}. +} diff --git a/man/dockerfiles.Rd b/man/dockerfiles.Rd index 6c07e74b..73e670a3 100644 --- a/man/dockerfiles.Rd +++ b/man/dockerfiles.Rd @@ -196,6 +196,11 @@ for the build and production phases.} \value{ The \code{{dockerfiler}} object, invisibly. } +\note{ +\code{add_dockerfile()}, \code{add_dockerfile_shinyproxy()}, and +\code{add_dockerfile_heroku()} are now soft deprecated; use the corresponding +\code{add_dockerfile_with_renv_*()} functions instead. +} \description{ Build a container containing your Shiny App. \code{add_dockerfile()} and \code{add_dockerfile_with_renv()} and \code{add_dockerfile_with_renv()} creates diff --git a/man/fill_desc.Rd b/man/fill_desc.Rd index 02d3e021..ff29cbda 100644 --- a/man/fill_desc.Rd +++ b/man/fill_desc.Rd @@ -36,16 +36,17 @@ fill_desc( \item{pkg}{Path to look for the DESCRIPTION. Default is \code{get_golem_wd()}.} -\item{author_first_name}{to be deprecated: use character for first name via -\code{authors = person(given = "authors_first_name")} instead} +\item{author_first_name}{Deprecated: use \code{authors = person(given = ...)} +instead} -\item{author_last_name}{to be deprecated: use character for last name via -\code{authors = person(given = "authors_last_name")} instead} +\item{author_last_name}{Deprecated: use \code{authors = person(family = ...)} +instead} -\item{author_email}{to be deprecated: use character for first name via -\code{authors = person(email = "author_email")} instead} +\item{author_email}{Deprecated: use \code{authors = person(email = ...)} +instead} -\item{author_orcid}{to be deprecated} +\item{author_orcid}{Deprecated: use +\code{authors = person(comment = c(ORCID = ...))} instead} \item{set_options}{logical; the default \code{TRUE} sets all recommended options but this can be suppressed with \code{FALSE}. For details on the diff --git a/man/get_sysreqs.Rd b/man/get_sysreqs.Rd deleted file mode 100644 index 49dd1264..00000000 --- a/man/get_sysreqs.Rd +++ /dev/null @@ -1,22 +0,0 @@ -% Generated by roxygen2: do not edit by hand -% Please edit documentation in R/get_sysreqs.R -\name{get_sysreqs} -\alias{get_sysreqs} -\title{Get system requirements (Deprecated)} -\usage{ -get_sysreqs(packages, quiet = TRUE, batch_n = 30) -} -\arguments{ -\item{packages}{character vector. Packages names.} - -\item{quiet}{Boolean. If \code{TRUE} the function is quiet.} - -\item{batch_n}{numeric. Number of simultaneous packages to ask.} -} -\value{ -A vector of system requirements. -} -\description{ -This function is now deprecated, and was moved to -\code{{dockerfiler}}. -} diff --git a/man/rstudio_deploy.Rd b/man/rstudio_deploy.Rd index fc7837c4..c0e29ad1 100644 --- a/man/rstudio_deploy.Rd +++ b/man/rstudio_deploy.Rd @@ -3,7 +3,6 @@ \name{add_positconnect_file} \alias{add_positconnect_file} \alias{add_rconnect_file} -\alias{add_rstudioconnect_file} \alias{add_shinyappsio_file} \alias{add_shinyserver_file} \alias{add_rscignore_file} @@ -11,8 +10,6 @@ \usage{ add_positconnect_file(golem_wd = get_golem_wd(), open = TRUE, pkg) -add_rstudioconnect_file(golem_wd = get_golem_wd(), open = TRUE, pkg) - add_shinyappsio_file(golem_wd = get_golem_wd(), open = TRUE, pkg) add_shinyserver_file(golem_wd = get_golem_wd(), open = TRUE, pkg) @@ -36,8 +33,6 @@ Additionally, adds a \code{.rscignore} at the root of the \code{{golem}} project } \note{ In previous versions, this function was called add_rconnect_file. - -\code{add_rstudioconnect_file} is now deprecated; replace by \code{\link[=add_positconnect_file]{add_positconnect_file()}}. } \section{List of excluded files in \code{.rscignore}}{ diff --git a/man/use_recommended.Rd b/man/use_recommended.Rd index 94e2710a..83aaa055 100644 --- a/man/use_recommended.Rd +++ b/man/use_recommended.Rd @@ -1,15 +1,9 @@ % Generated by roxygen2: do not edit by hand % Please edit documentation in R/use_recommended.R -\name{use_recommended_deps} -\alias{use_recommended_deps} +\name{use_recommended_tests} \alias{use_recommended_tests} \title{Add recommended elements} \usage{ -use_recommended_deps( - pkg = get_golem_wd(), - recommended = c("shiny", "DT", "attempt", "glue", "htmltools", "golem") -) - use_recommended_tests( golem_wd = get_golem_wd(), spellcheck = TRUE, @@ -22,8 +16,6 @@ use_recommended_tests( \arguments{ \item{pkg}{Deprecated, please use golem_wd instead} -\item{recommended}{A vector of recommended packages.} - \item{golem_wd}{Path to the root of the package. Default is \code{get_golem_wd()}.} \item{spellcheck}{Whether or not to use a spellcheck test.} @@ -42,8 +34,5 @@ prints potential spelling errors} Used for side-effects. } \description{ -\describe{ -\item{use_recommended_deps}{Adds \code{shiny}, \code{DT}, \code{attempt}, \code{glue}, \code{golem}, \code{htmltools} to dependencies} -\item{use_recommended_tests}{Adds a test folder and copy the golem tests} -} +Adds a test folder and copy the golem tests. } diff --git a/tests/testthat/_snaps/browser_button.md b/tests/testthat/_snaps/browser_button.md index 6962d27b..413fafd9 100644 --- a/tests/testthat/_snaps/browser_button.md +++ b/tests/testthat/_snaps/browser_button.md @@ -2,6 +2,9 @@ Code browser_button() + Condition + Warning in `browser_button()`: + browser_button() is currently soft deprecated and will be removed in future versions of {golem}. Output -- To be copied in your UI ----------------------------------------------------- actionButton("browser", "browser"), @@ -15,4 +18,3 @@ By default, this button will be hidden. To show it, open your web browser JavaScript console And run $('#browser').show(); - diff --git a/tests/testthat/test-add_dockerfiles.R b/tests/testthat/test-add_dockerfiles.R index cfa25b2e..020ae874 100644 --- a/tests/testthat/test-add_dockerfiles.R +++ b/tests/testthat/test-add_dockerfiles.R @@ -43,43 +43,52 @@ test_that("add_dockerfile works", { "usethis.quiet" = TRUE ), { - dockerfile_with_add_dockerfile <- add_dockerfile( - path = file.path( - dummy_golem, - "DESCRIPTION" + expect_warning( + dockerfile_with_add_dockerfile <- add_dockerfile( + path = file.path( + dummy_golem, + "DESCRIPTION" + ), + golem_wd = dummy_golem, + output = file.path( + dummy_golem, + "Dockerfile_add_dockerfile" + ), + open = FALSE ), - golem_wd = dummy_golem, - output = file.path( - dummy_golem, - "Dockerfile_add_dockerfile" - ), - open = FALSE + "add_dockerfile\\(\\) is currently soft deprecated" ) - dockerfile_with_add_dockerfile_shinyproxy <- add_dockerfile_shinyproxy( - path = file.path( - dummy_golem, - "DESCRIPTION" - ), - golem_wd = dummy_golem, - output = file.path( - dummy_golem, - "Dockerfile_add_dockerfile_shinyproxy" + expect_warning( + dockerfile_with_add_dockerfile_shinyproxy <- add_dockerfile_shinyproxy( + path = file.path( + dummy_golem, + "DESCRIPTION" + ), + golem_wd = dummy_golem, + output = file.path( + dummy_golem, + "Dockerfile_add_dockerfile_shinyproxy" + ), + open = FALSE ), - open = FALSE + "add_dockerfile_shinyproxy\\(\\) is currently soft deprecated" ) - dockerfile_with_add_dockerfile_heroku <- add_dockerfile_heroku( - path = file.path( - dummy_golem, - "DESCRIPTION" - ), - golem_wd = dummy_golem, - , - output = file.path( - dummy_golem, - "Dockerfile_add_dockerfile_heroku" + expect_warning( + dockerfile_with_add_dockerfile_heroku <- add_dockerfile_heroku( + path = file.path( + dummy_golem, + "DESCRIPTION" + ), + golem_wd = dummy_golem, + , + output = file.path( + dummy_golem, + "Dockerfile_add_dockerfile_heroku" + ), + open = FALSE ), - open = FALSE + "add_dockerfile_heroku\\(\\) is currently soft deprecated" ) } ) diff --git a/tests/testthat/test-add_files.R b/tests/testthat/test-add_files.R index df71a7ba..7e9b2809 100644 --- a/tests/testthat/test-add_files.R +++ b/tests/testthat/test-add_files.R @@ -165,22 +165,6 @@ test_that("add_file works", { ) ) } - res <- expect_warning( - add_ui_server_files( - golem_wd = "." - ) - ) - expect_exists( - "inst/app/ui.R" - ) - expect_exists( - "inst/app/server.R" - ) - res <- expect_warning( - add_ui_server_files( - golem_wd = "." - ) - ) }) }) diff --git a/tests/testthat/test-desc.R b/tests/testthat/test-desc.R index 2b2138c6..0319ea02 100644 --- a/tests/testthat/test-desc.R +++ b/tests/testthat/test-desc.R @@ -99,7 +99,8 @@ test_that("desc works", { ), repo_url = "http://repo_url.com", pkg_version = "0.0.0.9010" - ) + ), + "parameters of `fill_desc\\(\\)` are deprecated" ) } ) @@ -131,7 +132,8 @@ test_that("desc works", { author_orcid = NULL, repo_url = "http://repo_url.com", pkg_version = "0.0.0.9010" - ) + ), + "parameters of `fill_desc\\(\\)` are deprecated" ) expect_equal( as.character( diff --git a/tests/testthat/test-get_sysreqs.R b/tests/testthat/test-get_sysreqs.R deleted file mode 100644 index b0026069..00000000 --- a/tests/testthat/test-get_sysreqs.R +++ /dev/null @@ -1,5 +0,0 @@ -test_that("get_sysreqs works", { - expect_warning( - get_sysreqs() - ) -}) diff --git a/tests/testthat/test-make_dev.R b/tests/testthat/test-make_dev.R index 6e9dede9..e6ae0bd6 100644 --- a/tests/testthat/test-make_dev.R +++ b/tests/testthat/test-make_dev.R @@ -86,8 +86,11 @@ test_that("test browser_button", { withr::with_options( c("golem.quiet" = FALSE), { - output <- capture_output_lines( - browser_button() + expect_warning( + output <- capture_output_lines( + browser_button() + ), + "browser_button\\(\\) is currently soft deprecated" ) } ) diff --git a/tests/testthat/test-use_recommended.R b/tests/testthat/test-use_recommended.R index 209e0514..60a7f5d3 100644 --- a/tests/testthat/test-use_recommended.R +++ b/tests/testthat/test-use_recommended.R @@ -1,23 +1,3 @@ -test_that("use_recommended_deps works", { - testthat::with_mocked_bindings( - usethis_use_package = identity, - { - withr::with_options( - c( - "usethis.quiet" = TRUE - ), - { - expect_warning( - use_recommended_deps( - tempdir() - ) - ) - } - ) - } - ) -}) - test_that("use_recommended_tests works", { run_quietly_in_a_dummy_golem({ testthat::with_mocked_bindings( diff --git a/vignettes/a-getting-started.Rmd b/vignettes/a-getting-started.Rmd index d600a6e8..8a52fa53 100644 --- a/vignettes/a-getting-started.Rmd +++ b/vignettes/a-getting-started.Rmd @@ -154,15 +154,6 @@ golem::use_recommended_tests() About [tests in a package](https://r-pkgs.org/testing-basics.html). -### Use Recommended Packages - -This will add `{shiny}`, `{DT}`, `{attempt}`, `{glue}`, `{htmltools}`, and -`{golem}` as dependencies to your package: - -```{r} -golem::use_recommended_deps() -``` - ### Add various tools + If you want to change the default favicon: