Merge pull request #114 from TraderAlice/dev

feat: currency-aware UTA + FX rates UI

Author: luokerenx4

package.json

@@ -1,6 +1,6 @@
 {
   "name": "open-alice",
-  "version": "0.9.0-beta.9",
+  "version": "0.9.0-beta.10",
   "description": "File-based trading agent engine",
   "type": "module",
   "scripts": {

src/connectors/web/routes/trading.ts

@@ -58,6 +58,31 @@ export function createTradingRoutes(ctx: EngineContext) {
     return c.json(equity)
   })
 
+  // ==================== FX rates ====================
+
+  app.get('/fx-rates', async (c) => {
+    // Collect all unique currencies from positions across all accounts
+    const currencies = new Set<string>()
+    for (const uta of ctx.accountManager.resolve()) {
+      if (uta.health === 'offline') continue
+      try {
+        const positions = await uta.getPositions()
+        for (const p of positions) {
+          if (p.currency && p.currency !== 'USD') currencies.add(p.currency)
+        }
+        const account = await uta.getAccount()
+        if (account.baseCurrency && account.baseCurrency !== 'USD') currencies.add(account.baseCurrency)
+      } catch { /* skip unhealthy */ }
+    }
+
+    const rates: Array<{ currency: string; rate: number; source: string; updatedAt: string }> = []
+    for (const cur of currencies) {
+      const fx = await ctx.fxService.getRate(cur)
+      rates.push({ currency: cur, rate: fx.rate, source: fx.source, updatedAt: fx.updatedAt })
+    }
+    return c.json({ rates })
+  })
+
   // ==================== Per-account routes ====================
 
   // Reconnect

src/core/types.ts

@@ -1,5 +1,6 @@
 import type { QueryExecutor } from '@traderalice/opentypebb'
 import type { AccountManager } from '../domain/trading/index.js'
+import type { FxService } from '../domain/trading/fx-service.js'
 import type { SnapshotService } from '../domain/trading/snapshot/index.js'
 import type { CronEngine } from '../task/cron/engine.js'
 import type { Heartbeat } from '../task/heartbeat/index.js'
@@ -39,6 +40,7 @@ export interface EngineContext {
 
   // Trading (unified account model)
   accountManager: AccountManager
+  fxService: FxService
   snapshotService?: SnapshotService
   /** Reconnect connector plugins (Telegram, MCP-Ask, etc.). */
   reconnectConnectors: () => Promise<ReconnectResult>

src/domain/trading/__test__/e2e/ibkr-paper.e2e.spec.ts

@@ -83,6 +83,38 @@ describe('IbkrBroker — connectivity', () => {
   })
 })
 
+// ==================== Currency tracking (any time) ====================
+
+describe('IbkrBroker — currency tracking', () => {
+  beforeEach(({ skip }) => { if (!broker) skip('no IBKR paper account') })
+
+  it('getAccount returns baseCurrency field', async () => {
+    const account = await broker!.getAccount()
+    expect(account.baseCurrency).toBeDefined()
+    expect(typeof account.baseCurrency).toBe('string')
+    expect(account.baseCurrency.length).toBeGreaterThanOrEqual(3)
+    console.log(`  baseCurrency: ${account.baseCurrency}`)
+  })
+
+  it('positions carry currency field matching contract.currency', async () => {
+    const positions = await broker!.getPositions()
+    if (positions.length === 0) {
+      console.log('  no positions — skipping currency check')
+      return
+    }
+    for (const p of positions) {
+      expect(p.currency).toBeDefined()
+      expect(typeof p.currency).toBe('string')
+      expect(p.currency.length).toBeGreaterThanOrEqual(3)
+      // currency should match what the contract says
+      if (p.contract.currency) {
+        expect(p.currency).toBe(p.contract.currency)
+      }
+      console.log(`  ${p.contract.symbol}: currency=${p.currency}, avgCost=${p.avgCost}, marketPrice=${p.marketPrice}`)
+    }
+  })
+})
+
 // ==================== Order lifecycle (any time — limit orders accepted outside market hours) ====================
 
 describe('IbkrBroker — order lifecycle', () => {

src/main.ts

@@ -406,7 +406,7 @@ async function main() {
   const ctx: EngineContext = {
     config, connectorCenter, agentCenter, eventLog, toolCallLog, heartbeat, cronEngine, toolCenter,
     bbEngine: getSDKExecutor(),
-    accountManager, snapshotService,
+    accountManager, fxService, snapshotService,
     reconnectConnectors,
   }
 

ui/src/api/trading.ts

@@ -18,6 +18,12 @@ export const tradingApi = {
     return fetchJson('/api/trading/equity')
   },
 
+  // ==================== FX rates ====================
+
+  async fxRates(): Promise<{ rates: Array<{ currency: string; rate: number; source: string; updatedAt: string }> }> {
+    return fetchJson('/api/trading/fx-rates')
+  },
+
   // ==================== Per-account ====================
 
   async reconnectAccount(accountId: string): Promise<ReconnectResult> {

ui/src/api/types.ts

@@ -202,6 +202,7 @@ export interface TradingAccount {
 }
 
 export interface AccountInfo {
+  baseCurrency: string
   netLiquidation: number
   totalCashValue: number
   unrealizedPnL: number
@@ -224,6 +225,8 @@ export interface Position {
     multiplier?: number
     localSymbol?: string
   }
+  /** Currency denomination of all monetary fields. */
+  currency: string
   side: 'long' | 'short'
   quantity: string // Decimal serialized as string
   avgCost: number
@@ -354,6 +357,7 @@ export interface UTASnapshotSummary {
   timestamp: string
   trigger: string
   account: {
+    baseCurrency: string
     netLiquidation: string
     totalCashValue: string
     unrealizedPnL: string
@@ -364,6 +368,7 @@ export interface UTASnapshotSummary {
   }
   positions: Array<{
     aliceId: string
+    currency: string
     side: 'long' | 'short'
     quantity: string
     avgCost: string

ui/src/components/SnapshotDetail.tsx

@@ -51,6 +51,7 @@ export function SnapshotDetail({ snapshot, onClose }: SnapshotDetailProps) {
               <thead>
                 <tr className="bg-bg text-text-muted text-left">
                   <th className="px-2.5 py-1.5 font-medium">Symbol</th>
+                  <th className="px-2.5 py-1.5 font-medium text-center">Ccy</th>
                   <th className="px-2.5 py-1.5 font-medium text-right">Qty</th>
                   <th className="px-2.5 py-1.5 font-medium text-right">Avg Cost</th>
                   <th className="px-2.5 py-1.5 font-medium text-right">Mkt Price</th>
@@ -70,11 +71,12 @@ export function SnapshotDetail({ snapshot, onClose }: SnapshotDetailProps) {
                         </span>
                       </td>
                       <td className="px-2.5 py-1.5 text-right text-text tabular-nums">{p.quantity}</td>
-                      <td className="px-2.5 py-1.5 text-right text-text-muted tabular-nums">{fmtStr(p.avgCost)}</td>
-                      <td className="px-2.5 py-1.5 text-right text-text tabular-nums">{fmtStr(p.marketPrice)}</td>
-                      <td className="px-2.5 py-1.5 text-right text-text tabular-nums">{fmtStr(p.marketValue)}</td>
+                      <td className="px-2.5 py-1.5 text-center text-text-muted text-[10px] tabular-nums">{p.currency}</td>
+                      <td className="px-2.5 py-1.5 text-right text-text-muted tabular-nums">{fmtStr(p.avgCost, p.currency)}</td>
+                      <td className="px-2.5 py-1.5 text-right text-text tabular-nums">{fmtStr(p.marketPrice, p.currency)}</td>
+                      <td className="px-2.5 py-1.5 text-right text-text tabular-nums">{fmtStr(p.marketValue, p.currency)}</td>
                       <td className={`px-2.5 py-1.5 text-right font-medium tabular-nums ${pnl >= 0 ? 'text-green' : 'text-red'}`}>
-                        {fmtPnlStr(p.unrealizedPnL)}
+                        {fmtPnlStr(p.unrealizedPnL, p.currency)}
                       </td>
                     </tr>
                   )
@@ -153,15 +155,28 @@ function symbolFromAliceId(aliceId: string): string {
   return parts[parts.length - 1]
 }
 
-function fmtStr(s: string): string {
+const CURRENCY_SYMBOLS: Record<string, string> = {
+  USD: '$', HKD: 'HK$', EUR: '€', GBP: '£', JPY: '¥',
+  CNY: '¥', CNH: '¥', CAD: 'C$', AUD: 'A$', CHF: 'CHF ',
+  SGD: 'S$', KRW: '₩', INR: '₹', TWD: 'NT$', BRL: 'R$',
+}
+
+function currencySymbol(currency?: string): string {
+  if (!currency) return '$'
+  return CURRENCY_SYMBOLS[currency.toUpperCase()] ?? `${currency} `
+}
+
+function fmtStr(s: string, currency?: string): string {
   const n = Number(s)
   if (isNaN(n)) return s
-  return `$${n.toLocaleString('en-US', { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`
+  const sym = currencySymbol(currency)
+  return `${sym}${n.toLocaleString('en-US', { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`
 }
 
-function fmtPnlStr(s: string): string {
+function fmtPnlStr(s: string, currency?: string): string {
   const n = Number(s)
   if (isNaN(n)) return s
+  const sym = currencySymbol(currency)
   const sign = n >= 0 ? '+' : ''
-  return `${sign}$${n.toLocaleString('en-US', { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`
+  return `${sign}${sym}${n.toLocaleString('en-US', { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`
 }