TryGetChild throws exception when element not found

[prashantjain1991]

In latest version of ui-core, TryGetChild is throwing ControlNotFoundException. Ealier it use of returns false if element not found.
For example:
Public override bool Matches(WebControl actual)
{
var found = actual.TryGetChild(ByLocator.Xpath("//div"), timout);
return found;
}

In earlier core version above code was working fine. Now it's tthrowing ControlNotFoundException.

[dobriyanchik]

Hi @prashantjain1991
I reproduced the issue you provided with some additional inputs. Actually the behavior is not related to any last changes in UI core.

I can assume you get this exception just from time to time, not always. Looks like it's related to next scenario:

1. you pass as actual some control which is some PageObject child control
2. at the moment of TryGetChild call the actual itself does not exist in page object
3. In such case you get an ControlNotFoundException because of parent control absence, not the child you try to find

TryGetChild is designed to check existence of child control and does not handle issues with parents.

so what you can do is to slightly modify the method you provided:

public override bool Matches(WebControl actual)
{
    return actual.ExistsInPageObject() && actual.TryGetChild(ByLocator.Xpath("//div"), timeout);
}

in such case you first check parent for existence and just then try to get its child only if parent exists

please let me know if this works for you