lint errors

Author: andrew-parkes

simple-game-server-go/internal/game/allocated.go

@@ -28,6 +28,7 @@ func (g *Game) allocated(allocationID string) {
 	c := g.Config()
 	port, _ := c.Port.Int64()
 	maxPlayers, _ := strconv.ParseInt(c.Extra["maxPlayers"], 10, 32)
+
 	if maxPlayers == 0 {
 		maxPlayers = defaultMaxPlayers
 	}
@@ -52,12 +53,14 @@ func (g *Game) allocated(allocationID string) {
 func (g *Game) launchGame(port int64) {
 	g.logger.Info("allocated")
 	addr, err := net.ResolveTCPAddr("tcp4", fmt.Sprintf(":%d", port))
+
 	if err != nil {
 		g.logger.WithError(err).Error("error resolving TCP address")
 		return
 	}
 
 	gs, err := net.ListenTCP("tcp4", addr)
+
 	if err != nil {
 		g.logger.WithError(err).Error("error listening on TCP port")
 		return
@@ -69,6 +72,7 @@ func (g *Game) launchGame(port int64) {
 
 	for {
 		client, err := g.acceptClient(g.gameBind)
+
 		if err != nil {
 			if errors.Is(err, syscall.EINVAL) {
 				g.logger.Debug("server closed")
@@ -86,6 +90,7 @@ func (g *Game) launchGame(port int64) {
 // acceptClient accepts a new TCP connection and updates internal state.
 func (g *Game) acceptClient(server *net.TCPListener) (*net.TCPConn, error) {
 	client, err := server.AcceptTCP()
+
 	if err != nil {
 		return nil, err
 	}
@@ -114,8 +119,10 @@ func (g *Game) handleClient(client *net.TCPConn) {
 			"current_players": currentPlayers,
 		}).Info("client disconnected")
 	}()
+
 	for {
 		buf := make([]byte, 16)
+
 		if _, err := client.Read(buf); err != nil {
 			return
 		}
@@ -143,6 +150,7 @@ func (g *Game) readyForPlayers() {
 
 	if g.Config().Extra["readyTimeout"] != "" {
 		t, err := time.ParseDuration(g.Config().Extra["readyTimeout"])
+
 		if err != nil {
 			g.logger.WithError(err).Error("parsing ready timeout")
 		} else {

simple-game-server-go/main.go

@@ -34,6 +34,7 @@ func parseFlags(args []string) (string, string, string, error) {
 // If no valid targets are provided, it defaults to writing to stdout.
 func logWritersFromTargets(logTargets string, logFile string, logger *logrus.Logger) io.Writer {
 	targets := make([]io.Writer, 0)
+
 	for _, t := range splitAndTrim(logTargets) {
 		switch t {
 		case "stdout":
@@ -54,6 +55,7 @@ func logWritersFromTargets(logTargets string, logFile string, logger *logrus.Log
 			targets = append(targets, f)
 		}
 	}
+
 	// logFile takes precedence
 	if logFile != "" {
 		f, err := os.OpenFile(logFile, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0o666)
@@ -63,6 +65,7 @@ func logWritersFromTargets(logTargets string, logFile string, logger *logrus.Log
 			logger.WithError(err).Warning("could not open log file for writing")
 		}
 	}
+
 	if len(targets) == 0 {
 		return os.Stdout
 	}
@@ -72,6 +75,7 @@ func logWritersFromTargets(logTargets string, logFile string, logger *logrus.Log
 // splitAndTrim splits a string by the OS-specific path list separator and trims each part.
 func splitAndTrim(s string) []string {
 	parts := make([]string, 0)
+
 	for _, p := range filepath.SplitList(s) {
 		for _, t := range splitComma(p) {
 			trimmed := filepath.Clean(t)
@@ -86,6 +90,7 @@ func splitAndTrim(s string) []string {
 // splitComma splits a string by commas and trims each part, returning a slice of non-empty strings.
 func splitComma(s string) []string {
 	res := make([]string, 0)
+
 	for _, t := range strings.Split(s, ",") {
 		trimmed := strings.TrimSpace(t)
 		if trimmed != "" && trimmed != "." {
@@ -100,6 +105,7 @@ func main() {
 	logger.SetFormatter(&logrus.JSONFormatter{})
 
 	logTargets, logFile, tracebackLevel, err := parseFlags(os.Args[1:])
+
 	if err != nil {
 		logger.WithError(err).Fatal("error parsing flags")
 	}
@@ -112,6 +118,7 @@ func main() {
 	logger.Out = logWritersFromTargets(logTargets, logFile, logger)
 
 	g, err := game.New(logger)
+
 	if err != nil {
 		logger.WithError(err).Fatal("error creating game handler")
 	}