Skip to content

Commit 349b049

Browse files
Use the integrations.sh logo for GitHub and OpenAI presets (#1547)
The GitHub presets pointed at svgl's `github_dark.svg`, which is the dark-BACKGROUND variant: its paths are filled `#ffff`. Rendered on the light UI that is a white mark on a white surface, so the GitHub entry in the integrations list and in the connect dialog looked blank. `openai_dark.svg` has the same problem. Point both at integrations.sh instead, which `integration-favicon.tsx` calls executor's single logo source and which the neighbouring Figma, Stripe and Vercel presets already use. Those logos carry their own background, so they stay legible on either theme -- preset icons render as a plain `<img>` with no theme-aware variant selection, so one URL has to work on both. Co-authored-by: Rhys Sullivan <39114868+RhysSullivan@users.noreply.github.com>
1 parent 03d23b9 commit 349b049

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎packages/plugins/graphql/src/sdk/presets.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export const graphqlPresets: readonly GraphqlPreset[] = [
1515
summary: "Repos, issues, PRs, and users via GitHub's GraphQL API.",
1616
url: "https://api.github.com/graphql",
1717
endpoint: "https://api.github.com/graphql",
18-
icon: "https://svgl.app/library/github_dark.svg",
18+
icon: "https://integrations.sh/logo/github.com",
1919
featured: true,
2020
},
2121
{

‎packages/plugins/openapi/src/sdk/presets.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ const openApiOnlyPresets: readonly OpenApiPreset[] = [
8181
name: "GitHub REST",
8282
summary: "Repos, issues, pull requests, actions, and users.",
8383
url: "https://raw.githubusercontent.com/github/rest-api-description/main/descriptions/api.github.com/api.github.com.json",
84-
icon: "https://svgl.app/library/github_dark.svg",
84+
icon: "https://integrations.sh/logo/github.com",
8585
featured: true,
8686
authTemplate: [GITHUB_OAUTH_TEMPLATE],
8787
},
@@ -106,7 +106,7 @@ const openApiOnlyPresets: readonly OpenApiPreset[] = [
106106
name: "OpenAI",
107107
summary: "Models, files, responses, and fine-tuning.",
108108
url: "https://app.stainless.com/api/spec/documented/openai/openapi.documented.yml",
109-
icon: "https://svgl.app/library/openai_dark.svg",
109+
icon: "https://integrations.sh/logo/openai.com",
110110
featured: true,
111111
},
112112
{

0 commit comments

Comments
 (0)