Skip to content

Commit 53f2860

Browse files
Merge pull request #2 from VH-Lab/fix-windows-zip-failures-10291462098558351599
Fix zip failures on Windows in GitHub Actions workflow
2 parents 2a5a424 + 9fc549a commit 53f2860

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

.github/workflows/build_and_release.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,11 @@ jobs:
4949
run: |
5050
mkdir -p dist
5151
if [ "${{ runner.os }}" == "Windows" ]; then
52-
# Windows CMake builds output to bin due to our CMakeLists.txt fix
53-
zip -j dist/pyraview-win-x64.zip build/bin/*.dll build/bin/*.exe
54-
elif [ "${{ runner.os }}" == "macOS" ]; then
55-
zip -j dist/pyraview-mac-arm.zip build/bin/*.dylib build/bin/run_tests
52+
# Use 7-Zip (pre-installed on Windows runners)
53+
# 'a' is add, '-j' junk paths (like zip -j)
54+
7z a -tzip dist/pyraview-win-x64.zip ./build/bin/*.dll ./build/bin/*.exe
5655
else
57-
zip -j dist/pyraview-linux-x64.zip build/bin/*.so build/bin/run_tests
56+
zip -j dist/pyraview-${{ runner.os }}-${{ runner.arch }}.zip build/bin/*
5857
fi
5958
6059
- name: Upload Artifacts

0 commit comments

Comments
 (0)