[AUTO] feat: PATCH_REVIEW_STATS_PATH canonical, /health/detailed patch_review, /patch_review bot cmd, reset endpoint v8.2.18 — 5418 tests

- api/constants.py: PATCH_REVIEW_STATS_PATH single source of truth
- executor.py: imports PATCH_REVIEW_STATS_PATH from constants (fallback hardcoded)
- patch_review.py: uses constants path; adds POST /health/patch-review/reset
- health_detailed.py: includes patch_review check (informational, not in overall_ok)
- bot_slash.py: /patch_review slash command (rejections, escalations, SDK mode, recent steps)
- 5 new tests: reset endpoint, missing file safe, /health/detailed patch_review field

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Vaultifacts

solo_builder/api/blueprints/health_detailed.py

@@ -153,9 +153,25 @@ def health_detailed():
         repo_health_check = {"ok": True, "available": False, "error": str(exc),
                              "active_agents": [], "outcome_stats": {}}
 
+    # --- patch_review (informational — escalations indicate quality issues) ---
+    try:
+        from .patch_review import _load_stats as _pr_load
+        pr = _pr_load()
+        patch_review_check = {
+            "ok":             True,
+            "enabled":        pr.get("enabled", True),
+            "available":      pr.get("available", False),
+            "threshold_hits": pr.get("threshold_hits", 0),
+            "total_rejections": pr.get("total_rejections", 0),
+        }
+    except Exception as exc:
+        patch_review_check = {"ok": True, "enabled": True, "available": False,
+                               "threshold_hits": 0, "total_rejections": 0,
+                               "error": str(exc)}
+
     overall_ok = (state_check["ok"] and drift_check["ok"]
                   and alert_check["ok"] and slo_check_result["ok"])
-    # repo_health is intentionally excluded from overall_ok — AAWO absence is informational
+    # repo_health and patch_review are informational — excluded from overall_ok
 
     return jsonify({
         "ok": overall_ok,
@@ -165,5 +181,6 @@ def health_detailed():
             "metrics_alerts": alert_check,
             "slo_status":     slo_check_result,
             "repo_health":    repo_health_check,
+            "patch_review":   patch_review_check,
         },
     })

solo_builder/api/blueprints/patch_review.py

@@ -1,11 +1,11 @@
-"""PatchReviewer stats endpoint — GET /health/patch-review.
+"""PatchReviewer stats endpoint — GET /health/patch-review + POST /health/patch-review/reset.
 
 Reads the stats snapshot written by executor.py after each review_step()
 call.  Returns current threshold_hits, per-subtask rejection counts,
 SDK availability, and per-step review history so the dashboard can surface
 review quality metrics.
 
-Response shape:
+Response shape (GET):
   {
     "ok":               bool,
     "enabled":          bool,
@@ -22,18 +22,22 @@
        "escalated": int, "deferred": int}
     ]
   }
+
+Response shape (POST reset):
+  {"ok": bool, "reset": bool}
 """
 from __future__ import annotations
 
 import json
-from pathlib import Path
 
 from flask import Blueprint, jsonify
 
+from ..constants import PATCH_REVIEW_STATS_PATH
+
 patch_review_bp = Blueprint("patch_review", __name__)
 
-_SOLO       = Path(__file__).resolve().parents[3]
-_STATS_PATH = _SOLO / "state" / "patch_review_stats.json"
+# Expose for test patching
+_STATS_PATH = PATCH_REVIEW_STATS_PATH
 
 
 def _load_stats() -> dict:
@@ -58,3 +62,14 @@ def health_patch_review():
         "rejected_subtasks": s.get("rejected_subtasks", []),
         "recent_reviews":   s.get("recent_reviews", []),
     })
+
+
+@patch_review_bp.post("/health/patch-review/reset")
+def reset_patch_review():
+    """Delete the stats file so PatchReviewer counters start fresh next session."""
+    try:
+        _STATS_PATH.unlink(missing_ok=True)
+        reset = True
+    except Exception:
+        reset = False
+    return jsonify({"ok": True, "reset": reset})

solo_builder/api/constants.py

@@ -31,8 +31,9 @@
 CACHE_DIR     = Path(os.environ.get("CACHE_DIR",
                      str(_PROJECT_ROOT.parent / "claude" / "cache")))
 
-DAG_EXPORT_PATH    = _PROJECT_ROOT / "dag_export.json"
-DAG_IMPORT_TRIGGER = _PROJECT_ROOT / "state" / "dag_import_trigger.json"
+DAG_EXPORT_PATH         = _PROJECT_ROOT / "dag_export.json"
+DAG_IMPORT_TRIGGER      = _PROJECT_ROOT / "state" / "dag_import_trigger.json"
+PATCH_REVIEW_STATS_PATH = _PROJECT_ROOT / "state" / "patch_review_stats.json"
 
 _CONFIG_DEFAULTS = {
     "STALL_THRESHOLD": 5,

solo_builder/discord_bot/bot_slash.py

@@ -58,6 +58,7 @@ async def help_cmd(interaction: discord.Interaction) -> None:
             "`/task_progress task_id`            — per-branch progress for a single task\n"
             "`/heartbeat`                        — live counters from step.txt\n"
             "`/cache [clear:yes]`                — response cache disk stats (optional wipe)\n"
+            "`/patch_review`                     — PatchReviewer stats (rejections, escalations, SDK mode)\n"
             "`/help`                             — this message"
         )
 
@@ -705,3 +706,54 @@ async def undepends_cmd(interaction: discord.Interaction, target: str, dep: str)
             f"✅ Undepends queued: Task {target} no longer depends on Task {dep}\n"
             f"CLI will apply at the next step boundary."
         )
+
+    @bot.tree.command(name="patch_review", description="Show PatchReviewer stats (rejections, escalations, SDK mode)")
+    async def patch_review_cmd(interaction: discord.Interaction) -> None:
+        if not _b._allowed(interaction):
+            await interaction.response.send_message("❌ Wrong channel.", ephemeral=True)
+            return
+        try:
+            from api.constants import PATCH_REVIEW_STATS_PATH
+            stats_path = PATCH_REVIEW_STATS_PATH
+            if stats_path.exists():
+                s = json.loads(stats_path.read_text(encoding="utf-8"))
+            else:
+                s = {}
+        except Exception:
+            s = {}
+
+        enabled   = s.get("enabled", True)
+        available = s.get("available", False)
+        use_sdk   = s.get("use_sdk", True)
+        hits      = s.get("threshold_hits", 0)
+        total_rej = s.get("total_rejections", 0)
+        max_rej   = s.get("max_rejections", 3)
+        rejected  = s.get("rejected_subtasks", [])
+        recent    = s.get("recent_reviews", [])
+
+        sdk_mode = "SDK" if available else ("heuristic-only" if enabled else "disabled")
+        lines = [
+            f"**PatchReviewer** · {sdk_mode}",
+            f"⚠ {hits} escalated · ✗ {total_rej} rejected (limit {max_rej}/subtask)",
+        ]
+
+        if rejected:
+            lines.append("**Rejections by subtask:**")
+            for r in rejected[:8]:
+                lines.append(f"  `{r['name']}` ×{r['count']} — {r.get('last_reason', '')[:60]}")
+            if len(rejected) > 8:
+                lines.append(f"  … and {len(rejected) - 8} more")
+
+        if recent:
+            lines.append("**Recent steps:**")
+            for rv in recent[-5:]:
+                lines.append(
+                    f"  step {rv['step']}: "
+                    f"✓{rv.get('approved',0)} ✗{rv.get('rejected',0)} "
+                    f"⚠{rv.get('escalated',0)}"
+                )
+
+        if not s:
+            lines.append("_(no stats file — executor not yet run)_")
+
+        await interaction.response.send_message("\n".join(lines))

solo_builder/runners/executor.py

@@ -40,8 +40,15 @@
 
 logger = logging.getLogger("solo_builder")
 
-_METRICS_PATH     = os.path.join(_SOLO, "metrics.jsonl")
-_PATCH_STATS_PATH = os.path.join(_SOLO, "state", "patch_review_stats.json")
+_METRICS_PATH = os.path.join(_SOLO, "metrics.jsonl")
+
+# Single source of truth: api/constants.py defines the canonical path.
+# Import as a string to keep executor independent of the Flask layer.
+try:
+    from api.constants import PATCH_REVIEW_STATS_PATH as _PR_STATS
+    _PATCH_STATS_PATH = str(_PR_STATS)
+except Exception:
+    _PATCH_STATS_PATH = os.path.join(_SOLO, "state", "patch_review_stats.json")
 
 
 class _BudgetAdapter:

solo_builder/tests/test_patch_review_blueprint.py

@@ -201,6 +201,50 @@ def test_patch_review_in_dashboard_js(self):
         src = dash.read_text(encoding="utf-8")
         self.assertIn("pollPatchReviewDetailed", src)
 
+    # ── Reset endpoint ───────────────────────────────────────────────────
+
+    def test_reset_returns_ok(self):
+        resp = self.client.post("/health/patch-review/reset")
+        self.assertEqual(resp.status_code, 200)
+        d = json.loads(resp.data)
+        self.assertTrue(d["ok"])
+
+    def test_reset_deletes_stats_file(self):
+        import api.blueprints.patch_review as pr_mod
+        with tempfile.TemporaryDirectory() as tmp:
+            p = self._write_stats(tmp, {"threshold_hits": 5, "total_rejections": 2,
+                                        "enabled": True, "available": True, "use_sdk": True,
+                                        "max_rejections": 3, "rejected_subtasks": [],
+                                        "recent_reviews": []})
+            with patch.object(pr_mod, "_STATS_PATH", p):
+                resp = self.client.post("/health/patch-review/reset")
+        d = json.loads(resp.data)
+        self.assertTrue(d["reset"])
+        self.assertFalse(p.exists())
+
+    def test_reset_missing_file_still_returns_ok(self):
+        import api.blueprints.patch_review as pr_mod
+        with patch.object(pr_mod, "_STATS_PATH", Path("/nonexistent/x.json")):
+            resp = self.client.post("/health/patch-review/reset")
+        d = json.loads(resp.data)
+        self.assertTrue(d["ok"])
+
+    def test_reset_route_in_app(self):
+        rules = [r.rule for r in app.url_map.iter_rules()]
+        self.assertIn("/health/patch-review/reset", rules)
+
+    # ── /health/detailed includes patch_review ───────────────────────────
+
+    def test_health_detailed_includes_patch_review(self):
+        resp = self.client.get("/health/detailed")
+        self.assertEqual(resp.status_code, 200)
+        d = json.loads(resp.data)
+        self.assertIn("patch_review", d["checks"])
+        pr = d["checks"]["patch_review"]
+        self.assertIn("ok", pr)
+        self.assertIn("threshold_hits", pr)
+        self.assertIn("total_rejections", pr)
+
     def test_patch_review_div_in_dashboard_html(self):
         html = (
             Path(__file__).resolve().parents[1]

tools/generate_openapi.py

@@ -236,6 +236,10 @@
          "threshold_hits": {"type": "integer"}, "total_rejections": {"type": "integer"},
          "max_rejections": {"type": "integer"}, "rejected_subtasks": {"type": "array"},
      }}},
+    {"path": "/health/patch-review/reset", "method": "POST", "tag": "Health", "summary": "Reset PatchReviewer stats (deletes stats snapshot file)",
+     "response": {"type": "object", "properties": {
+         "ok": {"type": "boolean"}, "reset": {"type": "boolean"},
+     }}},
     # Policy
     {"path": "/policy/hitl",             "method": "GET", "tag": "Policy", "summary": "HITL policy rules from settings.json",
      "response": {"type": "object", "properties": {