Add unit tests for Soroban waitForConfirmation and validateConfirmedResult

[thlpkee20-wq]

Description

The confirmation polling and result-validation helpers in src/services/soroban/submitAttestation.ts handle timeout, failure, mismatch, and decode errors but are only partially exercised. Add unit tests with a mocked rpc.Server covering each terminal path.

Requirements and context

• Must be secure, tested, and documented
• Should be efficient and easy to review
• Relevant code: src/services/soroban/submitAttestation.ts, tests/unit/services/soroban/client.test.ts
• Mock getTransaction to drive SUCCESS/FAILED/NOT_FOUND sequences

Suggested execution

• Fork the repo and create a branch
• git checkout -b test/soroban-confirmation
• Implement changes
  • Test waitForConfirmation SUCCESS, FAILED, and timeout paths with fake timers
  • Test validateConfirmedResult for missing return value and root mismatch
  • Assert SorobanSubmissionError codes (CONFIRMATION_TIMEOUT, RESULT_MISMATCH)
• Validate security and correctness assumptions

Test and commit

• Run tests
  • npm test
• Cover edge cases
  • NOT_FOUND then SUCCESS, decode failure, missing timestamp, root mismatch
• Include test output and notes

Example commit message

test: soroban confirmation and result validation

Guidelines

• Minimum 95 percent test coverage
• Clear documentation
• Timeframe: 96 hours

[Danto1606]

@Danto1606 has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

I would like to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Danto1606 to this issue.

[drips-wave]

Congratulations, @Danto1606! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @Danto1606: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been marked as completed by a Drips Wave moderator for @Danto1606 as part of the Stellar Wave Program's 5th Wave 🥳

Moderator's reason: [Auto-assessed] The PR was successfully merged and provides comprehensive unit test coverage for the requested functions, including all edge cases and error paths specified in the issue. While the issue remains open, the PR explicitly linked it and the work is complete and accepted.

😎 @Danto1606: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.