Skip to content

Feature proposal: Add subtitle support to Local Video Player (implementation ready) #2

@FacundoSoler

Description

@FacundoSoler

你好,Weijie Zhao!

我叫 Facundo,来自阿根廷科尔多瓦市。我非常喜欢你的项目,我和我的女朋友一直在使用本地视频播放器功能一起观看电视剧,体验非常棒!(其他应用程序,比如 Teleparty,经常断开连接,而且问题较多。)

作为一名开发者,我想到是否可以为本地播放器添加字幕功能,幸运的是这是可行的。HTML5 支持 .VTT 字幕格式,可以通过在

我已经 fork 了你的项目进行测试,并创建了两个功能分支,逐步实现这些改进:

  • add-vtt-subtitles-support(添加基本的 .VTT 字幕支持)
  • add-subtitles-format-conversion(添加 subsrt-ts 库以支持多种字幕格式转换为 .VTT)

subsrt-ts 看起来是一个维护良好的库(最近一次更新是 3 个月前),有 11 位贡献者,每周大约 700 次下载(我研究了一些替代方案,这个整体上看起来是最好的)。

subsrt-ts GitHub 仓库:
https://github.com/rakuzen25/subsrt-ts

我的 fork 在这里:
https://github.com/FacundoSoler/website

示例截图 :
Image

如果你有兴趣,我很乐意为其中一个或两个分支创建 Pull Request,并为你的项目做出贡献!

附注:这段中文是我使用翻译工具编写的,因为我只会说英语和西班牙语。如有表达不准确之处,还请见谅。

此致
敬礼
Facundo




***** English translation ******

Hello Weijie Zhao,

My name is Facundo. I'm from Cordoba city, Argentina. I love your project and I have been using it with the Local video player feature with my girlfriend to watch TV series and it's great! (Other apps like Teleparty disconnect frequently and have quite a few issues.)

As I am a developer myself, I had the idea to see if it was possible to include subtitles in the local player, and luckily it is. HTML5 supports the .VTT subtitle format, which can be used by including a element inside the

I have created a fork of the project for testing and implemented two feature branches with incremental changes:

  • add-vtt-subtitles-support (Adds basic .VTT subtitle support)
  • add-subtitles-format-conversion (Adds the subsrt-ts library for converting multiple subtitle formats to .VTT)

The subsrt-ts library seems well maintained (latest update 3 months ago), has 11 contributors, and around 700 downloads per week. I reviewed alternatives, and this one appeared to be the best overall.

subsrt-ts GitHub repository:
https://github.com/rakuzen25/subsrt-ts

The fork is available here:
https://github.com/FacundoSoler/website

Please let me know if you would like me to create a Pull Request for either or both branches. I would be happy to contribute to your project.

Note: The Chinese version above was written using a translation tool, as I only speak English and Spanish. Please excuse any inaccuracies.

Kind regards,
Facundo

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions