Skip to content

Curvature Loss is Dimensionally Incorrect #1

Description

@bcui19

Hey I first wanted to say that this is great work. I also wanted to point out that in the non-amortized curvature loss if you look at the shapes:

grad_z is [batchsize x latent_dim]
grad_u is [batchsize x action_dim]

when I think in the paper grad_u should be [batchsize x latent_dim].

So, I think right now the way the curvature loss is formatted it is non-sensical dimensionally since if action_dim ≠ latent_dim or action_dim ≠ 1 then you'd get a dimension mismatch. Let me know if you have any questions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions