Summary
_installer_app_hint() and _is_installed_app_installer() in src/sifty/core/junk.py power the "only flag installers for apps you actually have installed" logic for the downloads-installers category, and they have no direct tests. Add unit tests for the suffix stripping (e.g. Discord-Setup-1.2.3.exe becomes discord) and the installed-name matching (substring both directions, plus the under-3-char guard).
Where
tests/test_junk.py, calling the pure helpers directly. No fixtures needed.
Acceptance criteria
Tip
These are pure functions, so this is a good first test contribution (like #20).
Summary
_installer_app_hint()and_is_installed_app_installer()insrc/sifty/core/junk.pypower the "only flag installers for apps you actually have installed" logic for thedownloads-installerscategory, and they have no direct tests. Add unit tests for the suffix stripping (e.g.Discord-Setup-1.2.3.exebecomesdiscord) and the installed-name matching (substring both directions, plus the under-3-char guard).Where
tests/test_junk.py, calling the pure helpers directly. No fixtures needed.Acceptance criteria
pytestgreenTip
These are pure functions, so this is a good first test contribution (like #20).