V_delta element.reference: char -> integer to match v1#54
Merged
Conversation
The v1 element_schema declares reference as integer with bounds [0, 100000]; existing corpora write reference as a JSON number. V_delta inherited V_alpha's char declaration, which rejected ~5,365 docs across the test corpora at validation time. Restoring the integer type lets v1 bodies migrate without coercion. Modeled on the integer field "direct" already in this schema: blank_value 0, mustNotHaveNaN true, constraints min/max instead of maxLength. default_value 1 matches v1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion follow-up to #53. After reverting the V_delta property-block renames, did-matlab CI on PR #140 surfaced a second incompatibility — a type mismatch on
element.reference:element.reference.typeelement_schema.json)integer1char"1"char"1"The corpus stores
referenceas a JSON number, so thechardeclaration rejects ~5,365 element docs across the test corpora (23 / 290 / 896 / 4156in 20211116 / B / Dab / JH respectively, plus 2 in PRED that fliptestPREDCorpusMigratesCleanlyto fail).This PR changes V_delta's declaration to
integer, matching v1, so v1 bodies migrate without any coercion. Modeled on the integer fielddirectalready in the same schema:type:char→integerblank_value:""→0default_value:"1"→1mustNotHaveNaN:false→true(consistent with other ints)constraints:maxLength: 256→min: 0, max: 100000(matches v1'sparameters: [0, 100000, 0])mustBeNonEmpty,mustBeScalar,queryable,ontology,documentationunchanged.Test plan
Generated by Claude Code
Generated by Claude Code