Problem
Data/SpellData_Warrior.lua Thunder Clap (spellID 6343 and ranks) currently stores only flat damage with no apCoefficient field. The engine's melee-direct path (Engine/SpellCalc.lua ComputeMeleeDirect Type-2) supports apCoefficient but Thunder Clap doesn't declare one, so the spell's damage is reported as flat-rank only and ignores attack power scaling entirely.
Empirical TBC value
WoWWiki Attack_power_coefficient archive (Warrior > Arms section) lists Thunder Clap as scaling at 12% AP (apCoefficient = 0.12).
Expected fix
Add apCoefficient = 0.12 to the Thunder Clap entry in Data/SpellData_Warrior.lua. With AP=2000 this contributes a 240 damage bonus to a flat ~300 damage rank, bringing displayed values in line with empirical TBC behavior.
Discovery context
Found during the AoE coefficient audit for #46 but deliberately excluded from that PR per scope discipline (Thunder Clap is a melee AP correction, not an AoE penalty correction). Filing as separate issue for clean tracking.
Acceptance criteria
Source
- WoWWiki Attack_power_coefficient archive (Warrior > Arms table)
Problem
Data/SpellData_Warrior.luaThunder Clap (spellID 6343 and ranks) currently stores only flat damage with noapCoefficientfield. The engine's melee-direct path (Engine/SpellCalc.luaComputeMeleeDirect Type-2) supportsapCoefficientbut Thunder Clap doesn't declare one, so the spell's damage is reported as flat-rank only and ignores attack power scaling entirely.Empirical TBC value
WoWWiki Attack_power_coefficient archive (Warrior > Arms section) lists Thunder Clap as scaling at 12% AP (
apCoefficient = 0.12).Expected fix
Add
apCoefficient = 0.12to the Thunder Clap entry inData/SpellData_Warrior.lua. With AP=2000 this contributes a 240 damage bonus to a flat ~300 damage rank, bringing displayed values in line with empirical TBC behavior.Discovery context
Found during the AoE coefficient audit for #46 but deliberately excluded from that PR per scope discipline (Thunder Clap is a melee AP correction, not an AoE penalty correction). Filing as separate issue for clean tracking.
Acceptance criteria
apCoefficient = 0.12.tests/pins the new value and assertsPipeline.Calculateproduces the expectedmin + AP * 0.12result.luacheck .clean,busted --verbosepasses.Source