ShowImage fails on non RGB888 images

[e-yes]

There are two files for testing: lena.png (exported with default GIMP settings) and lena2.png

Code to reproduce the issue:

from xgoscreen import LCD_2inch
lcd = LCD_2inch.LCD_2inch()
lcd.Init() #1 
from PIL import Image
im = Image.open("lena.png")
lcd.ShowImage(im)

the output:

File /usr/lib/python3.11/site-packages/xgoscreen/LCD_2inch.py:145, in LCD_2inch.ShowImage(self, Image, Xstart, Ystart)
    143 pix = self.np.zeros((self.width, self.height,2), dtype = self.np.uint8)
    144 #RGB888 >> RGB565
--> 145 pix[...,[0]] = self.np.add(self.np.bitwise_and(img[...,[0]],0xF8),self.np.right_shift(img[...,[1]],5))
    146 pix[...,[1]] = self.np.add(self.np.bitwise_and(self.np.left_shift(img[...,[1]],3),0xE0), self.np.right_shift(img[...,[2]],3))
    147 pix = pix.flatten().tolist()

ValueError: shape mismatch: value array of shape (240,1) could not be broadcast to indexing result of shape (240,320,1)

[e-yes]

Original images I have used for the test. In case if GitHub modifies original uploads (likely)
https://drive.google.com/drive/folders/1Tu0bO98xj86Q3vyMlfAGzSfXtoR2xDBC?usp=sharing

[jd3096-mpy]

Original images I have used for the test. In case if GitHub modifies original uploads (likely) https://drive.google.com/drive/folders/1Tu0bO98xj86Q3vyMlfAGzSfXtoR2xDBC?usp=sharing

See xgo wiki here https://www.yuque.com/luwudynamics/en/mxkaodwpo2h5zmvw#FC4FF
You can use the method lcd_picture
So the code shoule be:

from xgoedu import XGOEDU 
XGO_edu = XGOEDU()  
XGO_edu.lcd_picture('lena.png')

The image file display path is /home/pi/xgoPictures

[e-yes]

@jd3096-mpy thank you, it works. However, I'd like to know why random glitches occur and what I can do to mitigate it. Please take a look on #8

In [18]: from xgoscreen import LCD_2inch
    ...: lcd = LCD_2inch.LCD_2inch()
    ...: lcd.Init() #1 
    ...: from PIL import Image
    ...: im = Image.open("lena2.png")
    ...: lcd.ShowImage(im)
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[18], line 3
      1 from xgoscreen import LCD_2inch
      2 lcd = LCD_2inch.LCD_2inch()
----> 3 lcd.Init() #1 
      4 from PIL import Image
      5 im = Image.open("lena2.png")

File /usr/lib/python3.11/site-packages/xgoscreen/LCD_2inch.py:27, in LCD_2inch.Init(self)
     25 def Init(self):
     26     """Initialize dispaly"""  
---> 27     self.module_init()
     28     self.reset()
     30     self.command(0x36)

File /usr/lib/python3.11/site-packages/xgoscreen/lcdconfig.py:53, in RaspberryPi.module_init(self)
     51 self.GPIO.setup(self.DC_PIN, self.GPIO.OUT)
     52 self.GPIO.setup(self.BL_PIN, self.GPIO.OUT)
---> 53 self._pwm=self.GPIO.PWM(self.BL_PIN,self.BL_freq)
     54 self._pwm.start(100)
     55 if self.SPI!=None :

RuntimeError: A PWM object already exists for this GPIO channel

[jd3096-mpy]

@jd3096-mpy thank you, it works. However, I'd like to know why random glitches occur and what I can do to mitigate it. Please take a look on #8

In [18]: from xgoscreen import LCD_2inch
    ...: lcd = LCD_2inch.LCD_2inch()
    ...: lcd.Init() #1 
    ...: from PIL import Image
    ...: im = Image.open("lena2.png")
    ...: lcd.ShowImage(im)
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[18], line 3
      1 from xgoscreen import LCD_2inch
      2 lcd = LCD_2inch.LCD_2inch()
----> 3 lcd.Init() #1 
      4 from PIL import Image
      5 im = Image.open("lena2.png")

File /usr/lib/python3.11/site-packages/xgoscreen/LCD_2inch.py:27, in LCD_2inch.Init(self)
     25 def Init(self):
     26     """Initialize dispaly"""  
---> 27     self.module_init()
     28     self.reset()
     30     self.command(0x36)

File /usr/lib/python3.11/site-packages/xgoscreen/lcdconfig.py:53, in RaspberryPi.module_init(self)
     51 self.GPIO.setup(self.DC_PIN, self.GPIO.OUT)
     52 self.GPIO.setup(self.BL_PIN, self.GPIO.OUT)
---> 53 self._pwm=self.GPIO.PWM(self.BL_PIN,self.BL_freq)
     54 self._pwm.start(100)
     55 if self.SPI!=None :

RuntimeError: A PWM object already exists for this GPIO channel

The display screen driver has been modified based on the official Waveshare website driver.
https://www.waveshare.net/wiki/2.4inch_LCD_Module#python

All our drivers are open source, and you can find pin definitions and other display drivers here.
https://github.com/Xgorobot/XGO-PythonLib/tree/master/xgoscreen

GPIO setting
spi=spidev.SpiDev(0,0),spi_freq=40000000,rst = 27,dc = 25,bl = 0

You can adjust the screen brightness using PWM through the bl_pin, but I believe that repeated use of this method may lead to PWM conflicts. You can try removing the PWM here, and it should not affect the screen's functionality.