Description
Two suite scripts are inconsistently named against the rest of the project.
1. BasicUnaryUpdateExpressions is missing the TestSuite suffix. Every other one of the 47 registered suites ends in TestSuite. This is the only exception, and it makes the suite easy to miss in greps, glob patterns and tooling that keys on the naming convention — it was in fact missed in the first pass of this audit for exactly that reason. It should become BasicUnaryUpdateExpressionsTestSuite.
2. BasicMathTestSuite should be BasicMathsTestSuite. House spelling.
Both renames touch the same five places each:
- the script folder under
projects/xUnit/scripts/
- the
.gml file, and the constructor function name inside it
- the
.yy file, and its %Name and name fields
- the asset entry in
projects/xUnit/xUnit.yyp
- the
testFramework.addSuite(...) call in projects/xUnit/objects/objRunner/Create_0.gml
I have checked the rest of the repo: no CI workflow, Python tooling, config file or documentation hardcodes either suite name, and there are no configured --skip-tests patterns referencing them. objRunner/Create_0.gml also carries a single_test_path example pointing at BasicArrayTestSuite, which is unaffected.
One caveat worth noting: test results are keyed by suite name, so any stored result history, published report or Slack statistic will treat the renamed suites as new suites with no prior history. That is acceptable but should not come as a surprise when the first run after the merge lands.
Ordering: land this before #341, the BasicUnaryUpdateExpressions fact-splitting refactor, so that refactor does not have to be replayed across a moved file.
Renaming a script asset is best done through the GameMaker IDE rather than by hand, so the .yy and .yyp entries stay consistent.
Script Name
BasicUnaryUpdateExpressions, BasicMathTestSuite
Steps To The Task
Description
Two suite scripts are inconsistently named against the rest of the project.
1.
BasicUnaryUpdateExpressionsis missing theTestSuitesuffix. Every other one of the 47 registered suites ends inTestSuite. This is the only exception, and it makes the suite easy to miss in greps, glob patterns and tooling that keys on the naming convention — it was in fact missed in the first pass of this audit for exactly that reason. It should becomeBasicUnaryUpdateExpressionsTestSuite.2.
BasicMathTestSuiteshould beBasicMathsTestSuite. House spelling.Both renames touch the same five places each:
projects/xUnit/scripts/.gmlfile, and the constructor function name inside it.yyfile, and its%Nameandnamefieldsprojects/xUnit/xUnit.yyptestFramework.addSuite(...)call inprojects/xUnit/objects/objRunner/Create_0.gmlI have checked the rest of the repo: no CI workflow, Python tooling, config file or documentation hardcodes either suite name, and there are no configured
--skip-testspatterns referencing them.objRunner/Create_0.gmlalso carries asingle_test_pathexample pointing atBasicArrayTestSuite, which is unaffected.One caveat worth noting: test results are keyed by suite name, so any stored result history, published report or Slack statistic will treat the renamed suites as new suites with no prior history. That is acceptable but should not come as a surprise when the first run after the merge lands.
Ordering: land this before #341, the
BasicUnaryUpdateExpressionsfact-splitting refactor, so that refactor does not have to be replayed across a moved file.Renaming a script asset is best done through the GameMaker IDE rather than by hand, so the
.yyand.yypentries stay consistent.Script Name
BasicUnaryUpdateExpressions, BasicMathTestSuite
Steps To The Task
BasicUnaryUpdateExpressionstoBasicUnaryUpdateExpressionsTestSuitevia the GameMaker IDEBasicMathTestSuitetoBasicMathsTestSuitevia the GameMaker IDE.gmlmatches the new asset name%Nameandnamefields in each.yymatch, and thatxUnit.yyppoints at the new pathstestFramework.addSuite(...)calls inobjRunner/Create_0.gml