Description
ResourceTimeSourceTestSuite was never covered by the summer 2024 refactor campaign. It holds 39 asserts in 9 tests across 634 lines — 4.3 asserts per test. Five are addFact() and four are addTestAsync().
| Test |
Kind |
Asserts |
Lines |
Time Sources: Existence |
fact |
11 |
54 |
Time Sources: Constant Values |
fact |
10 |
21 |
Time Sources: Reconfiguration |
fact |
5 |
31 |
Time Sources: Parents and Children |
fact |
3 |
26 |
Time Sources: State Transitions |
fact |
1 |
66 |
Time Sources: Expiry Frames |
async |
2 |
170 |
Time Sources: Self Destruction |
async |
4 |
59 |
Time Sources: Sibling Destruction |
async |
1 |
65 |
Time Sources: Time delta propagation |
async |
— |
— |
The five synchronous facts split straightforwardly and should be the focus. Constant Values in particular is ten independent constant checks in one fact and should become ten facts.
The four async tests should be treated with care. Each drives a time source across multiple frames and has its own timeout; splitting one into N tests means N separate multi-frame runs, which multiplies suite wall-clock time. Split these only where a scenario is genuinely independent, and prefer leaving a single stateful progression intact.
Target: roughly 35–40 tests.
Script Name
ResourceTimeSourceTestSuite
Steps To The Task
Description
ResourceTimeSourceTestSuitewas never covered by the summer 2024 refactor campaign. It holds 39 asserts in 9 tests across 634 lines — 4.3 asserts per test. Five areaddFact()and four areaddTestAsync().Time Sources: ExistenceTime Sources: Constant ValuesTime Sources: ReconfigurationTime Sources: Parents and ChildrenTime Sources: State TransitionsTime Sources: Expiry FramesTime Sources: Self DestructionTime Sources: Sibling DestructionTime Sources: Time delta propagationThe five synchronous facts split straightforwardly and should be the focus.
Constant Valuesin particular is ten independent constant checks in one fact and should become ten facts.The four async tests should be treated with care. Each drives a time source across multiple frames and has its own timeout; splitting one into N tests means N separate multi-frame runs, which multiplies suite wall-clock time. Split these only where a scenario is genuinely independent, and prefer leaving a single stateful progression intact.
Target: roughly 35–40 tests.
Script Name
ResourceTimeSourceTestSuite
Steps To The Task
<original_name> #NTime Sources: Constant Valuesinto one fact per constant